LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "lizhijian@fujitsu.com" <lizhijian@fujitsu.com>
To: Shuah Khan <skhan@linuxfoundation.org>,
	"lizhijian@fujitsu.com" <lizhijian@fujitsu.com>,
	"shuah@kernel.org" <shuah@kernel.org>,
	"linux-kselftest@vger.kernel.org"
	<linux-kselftest@vger.kernel.org>
Cc: "philip.li@intel.com" <philip.li@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v2 1/3] selftests/sync: Remove the deprecated config SYNC
Date: Fri, 27 Aug 2021 01:35:34 +0000	[thread overview]
Message-ID: <69835666-1710-5103-fb06-2636a3a3c5bb@fujitsu.com> (raw)
In-Reply-To: <239339d5-5626-ea04-97db-7dc070a48636@linuxfoundation.org>



On 27/08/2021 05:10, Shuah Khan wrote:
> On 8/25/21 7:58 PM, Li Zhijian wrote:
>> SYNC was removed since aff9da10e21 ("staging/android: make sync_timeline internal to sw_sync")
>> LKP/0Day will check if all configs listing under selftests are able to be enabled properly.
>>
>
> Can you please state what you arr fxing and also keep the sentences
> 75 chars or less.
>
> Where is LKP warning? 
https://01.org/lkp
LKP(aka. 0Day) often reports issue related to the *recent* kernel commits/WIP patches publicly.
As the LKP keeping improvement, it will cover more aspects in the kernel so that more issues will be detected.

So in this case, which is related to too old kernel, it just reported it internally.


> Include the warning and explain why this
> change is necessary.
- it's not reasonable to keep the deprecated configs, right ?

- In my understanding, configs under kselftests are recommended by corresponding tests.
So if some configs are missing, it will impact the testing results

Do you mean the commit log should include above 2 reasons ?

Thanks

>
>> For the missing configs, it will report something like:
>> LKP WARN miss config CONFIG_SYNC= of sync/config
>>
>> CC: Philip Li <philip.li@intel.com>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
>> ---
>
> thanks,
> -- Shuah
>
>

  reply	other threads:[~2021-08-27  1:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-26  1:58 [PATCH v2 0/3] kselftests: clean configs Li Zhijian
2021-08-26  1:58 ` [PATCH v2 1/3] selftests/sync: Remove the deprecated config SYNC Li Zhijian
2021-08-26 21:10   ` Shuah Khan
2021-08-27  1:35     ` lizhijian [this message]
2021-08-27 17:00       ` Shuah Khan
2021-08-26  1:58 ` [PATCH v2 2/3] selftests/cpufreq: Rename DEBUG_PI_LIST to DEBUG_PLIST Li Zhijian
2021-08-26 21:10   ` Shuah Khan
2021-08-26  1:58 ` [PATCH v2 3/3] selftests/wireguard: " Li Zhijian
2021-08-26 21:11   ` Shuah Khan
2021-08-27 14:23   ` Jason A. Donenfeld

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=69835666-1710-5103-fb06-2636a3a3c5bb@fujitsu.com \
    --to=lizhijian@fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=philip.li@intel.com \
    --cc=shuah@kernel.org \
    --cc=skhan@linuxfoundation.org \
    --subject='Re: [PATCH v2 1/3] selftests/sync: Remove the deprecated config SYNC' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).