From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7E85C4338F for ; Fri, 30 Jul 2021 14:12:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8DBBF60720 for ; Fri, 30 Jul 2021 14:12:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239080AbhG3OMw (ORCPT ); Fri, 30 Jul 2021 10:12:52 -0400 Received: from mga01.intel.com ([192.55.52.88]:9264 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238962AbhG3OMo (ORCPT ); Fri, 30 Jul 2021 10:12:44 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10060"; a="235014994" X-IronPort-AV: E=Sophos;i="5.84,282,1620716400"; d="scan'208";a="235014994" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jul 2021 07:12:39 -0700 X-IronPort-AV: E=Sophos;i="5.84,282,1620716400"; d="scan'208";a="518961685" Received: from spichard-mobl1.amr.corp.intel.com (HELO [10.212.106.239]) ([10.212.106.239]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jul 2021 07:12:39 -0700 Subject: Re: [PATCH v1] ASoC: Intel: kbl_da7219_max98357a: fix drv_name To: Cezary Rojewski , Lukasz Majczak Cc: upstream@semihalf.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20210730115906.144300-1-lma@semihalf.com> <58b46549-9b42-1832-b1e1-680d56c3f393@linux.intel.com> From: Pierre-Louis Bossart Message-ID: <6a0866a7-aec4-69d9-eb70-07931952b732@linux.intel.com> Date: Fri, 30 Jul 2021 09:12:36 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/30/21 9:05 AM, Cezary Rojewski wrote: > On 2021-07-30 3:55 PM, Pierre-Louis Bossart wrote: >> On 7/30/21 6:59 AM, Lukasz Majczak wrote: > > ... > >>> @@ -113,7 +113,7 @@ struct snd_soc_acpi_mach >>> snd_soc_acpi_intel_kbl_machines[] = { >>>       }, >>>       { >>>           .id = "DLGS7219", >>> -        .drv_name = "kbl_da7219_mx98373", >>> +        .drv_name = "kbl_da7219_max98373", >> >> this one is wrong though? The correct name was already present, you're >> reverting back to the wrong name. >> >> there's another one that I missed, do you mind changing this as well? >> >> soc-acpi-intel-cml-match.c:             .drv_name = >> "cml_da7219_max98357a", >> >> Should be "cml_da7219_mx98357a" >> >> > > Not saying 'nay' or 'yay' but why is configuration first available on > KBL platforms being renamed to 'cml_XXX'? The same bxt_da7219_max98357a.c machine driver is used for multiple devices. static const struct platform_device_id bxt_board_ids[] = { { .name = "bxt_da7219_mx98357a" }, { .name = "glk_da7219_mx98357a" }, { .name = "cml_da7219_mx98357a" }, { } }; MODULE_DEVICE_TABLE(platform, bxt_board_ids); Why there are different drivers for KBL and BXT is probably lost in history.