LKML Archive on
help / color / mirror / Atom feed
From: Marc Zyngier <>
To: Florian Fainelli <>,
	Santosh Shilimkar <>
Subject: Re: [PATCH] soc: ti: QMSS: Fix usage of irq_set_affinity_hint
Date: Tue, 30 Oct 2018 18:29:49 +0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 30/10/18 17:02, Florian Fainelli wrote:
> On 10/30/18 4:11 AM, Marc Zyngier wrote:
>> The Keystone QMSS driver is pretty damaged, in the sense that it
>> does things like this:
>> 	irq_set_affinity_hint(irq, to_cpumask(&cpu_map));
>> where cpu_map is a local variable. As we leave the function, this
>> will point to nowhere-land, and things will end-up badly.
>> Instead, let's use a proper cpumask that gets allocated, giving
>> the driver a chance to actually work with things like irqbalance
>> as well as have a hypothetical 64bit future.
> Since this is at least the second patch from you that I can see in this
> area, would it make sense to sprinkle object_is_on_stack() checks
> throughout irq_set_affinity_hint() to help catch offenders?

I think I nuked the only two offenders in the tree. And to be honest,
I'm far more worried about the use of to_cpumask() itself, because this
can be wrong in quite a number of ways.

As much as I dislike checkpatch, I wonder if having a rule checking for
the usage of to_cpumask() would be a good idea...


Jazz is not dead. It just smells funny...

  reply	other threads:[~2018-10-30 18:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-30 11:11 Marc Zyngier
2018-10-30 17:02 ` Florian Fainelli
2018-10-30 18:29   ` Marc Zyngier [this message]
2018-10-30 17:09 ` Santosh Shilimkar
2018-10-30 17:15 ` Santosh Shilimkar
2018-10-30 17:18 ` Santosh Shilimkar
2018-10-30 19:00   ` Greg Kroah-Hartman
2018-10-30 19:05     ` santosh.shilimkar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \
    --subject='Re: [PATCH] soc: ti: QMSS: Fix usage of irq_set_affinity_hint' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).