LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Nathan Chancellor <nathan@kernel.org>
To: "Gustavo A. R. Silva" <gustavoars@kernel.org>,
	Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
Cc: ntfs3@lists.linux.dev, linux-kernel@vger.kernel.org,
	linux-hardening@vger.kernel.org
Subject: Re: [PATCH][next] fs/ntfs3: Fix fall-through warnings for Clang
Date: Wed, 18 Aug 2021 16:29:18 -0700	[thread overview]
Message-ID: <6b9a6c49-1b32-c5bc-6313-b0a888e93923@kernel.org> (raw)
In-Reply-To: <20210818222146.GA312859@embeddedor>

On 8/18/2021 3:21 PM, Gustavo A. R. Silva wrote:
> Fix the following fallthrough warnings:
> 
> fs/ntfs3/inode.c:1792:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
> fs/ntfs3/index.c:178:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
> 
> This helps with the ongoing efforts to globally enable
> -Wimplicit-fallthrough for Clang.
> 
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>

Reviewed-by: Nathan Chancellor <nathan@kernel.org>

> ---
>   fs/ntfs3/index.c | 1 +
>   fs/ntfs3/inode.c | 1 +
>   2 files changed, 2 insertions(+)
> 
> diff --git a/fs/ntfs3/index.c b/fs/ntfs3/index.c
> index 6aa9540ece47..76eae60b7fce 100644
> --- a/fs/ntfs3/index.c
> +++ b/fs/ntfs3/index.c
> @@ -175,6 +175,7 @@ static inline NTFS_CMP_FUNC get_cmp_func(const struct INDEX_ROOT *root)
>   		default:
>   			break;
>   		}
> +		break;
>   	default:
>   		break;
>   	}
> diff --git a/fs/ntfs3/inode.c b/fs/ntfs3/inode.c
> index bf51e294432e..a573c6e98cb8 100644
> --- a/fs/ntfs3/inode.c
> +++ b/fs/ntfs3/inode.c
> @@ -1789,6 +1789,7 @@ int ntfs_unlink_inode(struct inode *dir, const struct dentry *dentry)
>   	switch (err) {
>   	case 0:
>   		drop_nlink(inode);
> +		break;
>   	case -ENOTEMPTY:
>   	case -ENOSPC:
>   	case -EROFS:
> 


  reply	other threads:[~2021-08-18 23:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-18 22:21 Gustavo A. R. Silva
2021-08-18 23:29 ` Nathan Chancellor [this message]
2021-08-27 16:26 ` Konstantin Komarov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6b9a6c49-1b32-c5bc-6313-b0a888e93923@kernel.org \
    --to=nathan@kernel.org \
    --cc=almaz.alexandrovich@paragon-software.com \
    --cc=gustavoars@kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ntfs3@lists.linux.dev \
    --subject='Re: [PATCH][next] fs/ntfs3: Fix fall-through warnings for Clang' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).