LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: John Garry <john.garry@huawei.com>
To: Hannes Reinecke <hare@suse.de>,
	Bart Van Assche <bvanassche@acm.org>,
	"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: <satishkh@cisco.com>, <sebaddel@cisco.com>, <kartilak@cisco.com>,
	<jejb@linux.ibm.com>, <linux-scsi@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <hch@lst.de>
Subject: Re: [PATCH 0/3] Remove scsi_cmnd.tag
Date: Thu, 19 Aug 2021 10:09:27 +0100	[thread overview]
Message-ID: <6c83bd7f-9fd2-1b43-627f-615467fa55d4@huawei.com> (raw)
In-Reply-To: <6090371d-9688-11ae-8219-ba9929a96526@suse.de>

On 19/08/2021 08:50, Hannes Reinecke wrote:
>>>    select CPU_32v4 if ARCH_RPC
>>
>> Does that build fully for xconfig or any others which you tried?
>>
>  > Yep, xconfig and full build works.
> 
> Well.
> 
> Would've worked if you hadn't messed up tag handling for acornscsi :-)
>  > Besides: tag handling in acornscsi (and fas216, for that matter) seems
> to be completely broken.
> 
> Consider this beauty:
> 
> #ifdef CONFIG_SCSI_ACORNSCSI_TAGGED_QUEUE
>         /*
>          * tagged queueing - allocate a new tag to this command
>          */
>         if (SCpnt->device->simple_tags) {
>             SCpnt->device->current_tag += 1;
>             if (SCpnt->device->current_tag == 0)
>                 SCpnt->device->current_tag = 1;
>             SCpnt->tag = SCpnt->device->current_tag;
>         } else
> #endif

So isn't this just using the scsi_cmnd.tag as it own scribble?

> 
> which is broken on _soo many_ counts.
> Not only does it try to allocate its own tags, the code also assumes 
> that a tag value of '0' indicates that tagged queueing is not active:
> 

In case you missed it, Arnd B tried to clear out some old platforms 
earlier this year. With respect to rpc, Russell King apparently still 
uses it and has some SCSI patches:

https://lore.kernel.org/lkml/20210109174357.GB1551@shell.armlinux.org.uk/

I wonder what they are and maybe we can check. Anyway... I'd run any 
changes by him...

> static
> void acornscsi_abortcmd(AS_Host *host, unsigned char tag)
> {
>      host->scsi.phase = PHASE_ABORTED;
>      sbic_arm_write(host, SBIC_CMND, CMND_ASSERTATN);
> 
>      msgqueue_flush(&host->scsi.msgs);
> #ifdef CONFIG_SCSI_ACORNSCSI_TAGGED_QUEUE
>      if (tag)
>          msgqueue_addmsg(&host->scsi.msgs, 2, ABORT_TAG, tag);
>      else
> #endif
>          msgqueue_addmsg(&host->scsi.msgs, 1, ABORT);
> }
> 
> And, of course, there's the usual confusion about when to check for
> sdev->tagged_supported and sdev->simple_tags.
> 
> Drop me a note if I can give a hand.

Thanks! Let's see what happens to the series which you just sent.

  reply	other threads:[~2021-08-19  9:09 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-13 13:49 John Garry
2021-08-13 13:49 ` [PATCH 1/3] scsi: wd719: Stop using scsi_cmnd.tag John Garry
2021-08-13 16:30   ` Hannes Reinecke
2021-08-14  3:11   ` Bart Van Assche
2021-08-13 13:49 ` [PATCH 2/3] scsi: fnic: Stop setting scsi_cmnd.tag John Garry
2021-08-13 16:31   ` Hannes Reinecke
2021-08-14  3:17   ` Bart Van Assche
2021-08-14  7:39     ` Christoph Hellwig
2021-08-14 12:35       ` Hannes Reinecke
2021-08-16 10:00         ` John Garry
2021-08-16 11:11           ` Hannes Reinecke
2021-08-13 13:49 ` [PATCH 3/3] scsi: Remove scsi_cmnd.tag John Garry
2021-08-13 16:31   ` Hannes Reinecke
2021-08-14  3:18   ` Bart Van Assche
2021-08-14  7:40 ` [PATCH 0/3] " Christoph Hellwig
2021-08-16 17:34 ` Martin K. Petersen
2021-08-18 18:08   ` John Garry
2021-08-18 18:46     ` Martin K. Petersen
2021-08-19  2:41     ` Bart Van Assche
2021-08-19  7:15       ` Hannes Reinecke
2021-08-19  7:27         ` John Garry
2021-08-19  7:50           ` Hannes Reinecke
2021-08-19  9:09             ` John Garry [this message]
2021-08-24  4:03 ` Martin K. Petersen
2021-08-24  7:54   ` John Garry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6c83bd7f-9fd2-1b43-627f-615467fa55d4@huawei.com \
    --to=john.garry@huawei.com \
    --cc=bvanassche@acm.org \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=jejb@linux.ibm.com \
    --cc=kartilak@cisco.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=satishkh@cisco.com \
    --cc=sebaddel@cisco.com \
    --subject='Re: [PATCH 0/3] Remove scsi_cmnd.tag' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).