LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jongsung Kim <neidhard.kim@lge.com>
To: Guenter Roeck <linux@roeck-us.net>,
	Wim Van Sebroeck <wim@linux-watchdog.org>,
	linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Chanho Min <chanho.min@lge.com>
Subject: Re: [PATCH v3] watchdog: sp805: add restart handler
Date: Wed, 9 May 2018 11:40:19 +0900	[thread overview]
Message-ID: <6d09e8c6-d6b9-d0ea-2496-1b1cd1487808@lge.com> (raw)
In-Reply-To: <1b084bff-84fd-18fa-7bee-dd00e33405a2@roeck-us.net>

On 05/04/2018 10:11 PM, Guenter Roeck wrote:
> On 05/03/2018 11:05 PM, Jongsung Kim wrote:
>> Add restart handler for SP805 watchdog so that the driver can be
>> used to reboot the system.
>>
>> Signed-off-by: Jongsung Kim <neidhard.kim@lge.com>
>> Cc: Guenter Roeck <linux@roeck-us.net>
>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>
>> ---
>
> For future patches: change log goes here, please.
>
> Thanks,
> Guenter

Thank you for your review and kind comments.
JS

>
>>   drivers/watchdog/sp805_wdt.c | 14 ++++++++++++++
>>   1 file changed, 14 insertions(+)
>>
>> diff --git a/drivers/watchdog/sp805_wdt.c b/drivers/watchdog/sp805_wdt.c
>> index 03805bc..9849db0 100644
>> --- a/drivers/watchdog/sp805_wdt.c
>> +++ b/drivers/watchdog/sp805_wdt.c
>> @@ -121,6 +121,18 @@ static unsigned int wdt_timeleft(struct watchdog_device *wdd)
>>       return div_u64(load, rate);
>>   }
>>   +static int
>> +wdt_restart(struct watchdog_device *wdd, unsigned long mode, void *cmd)
>> +{
>> +    struct sp805_wdt *wdt = watchdog_get_drvdata(wdd);
>> +
>> +    writel_relaxed(0, wdt->base + WDTCONTROL);
>> +    writel_relaxed(0, wdt->base + WDTLOAD);
>> +    writel_relaxed(INT_ENABLE | RESET_ENABLE, wdt->base + WDTCONTROL);
>> +
>> +    return 0;
>> +}
>> +
>>   static int wdt_config(struct watchdog_device *wdd, bool ping)
>>   {
>>       struct sp805_wdt *wdt = watchdog_get_drvdata(wdd);
>> @@ -197,6 +209,7 @@ static const struct watchdog_ops wdt_ops = {
>>       .ping        = wdt_ping,
>>       .set_timeout    = wdt_setload,
>>       .get_timeleft    = wdt_timeleft,
>> +    .restart    = wdt_restart,
>>   };
>>     static int
>> @@ -230,6 +243,7 @@ sp805_wdt_probe(struct amba_device *adev, const struct amba_id *id)
>>       spin_lock_init(&wdt->lock);
>>       watchdog_set_nowayout(&wdt->wdd, nowayout);
>>       watchdog_set_drvdata(&wdt->wdd, wdt);
>> +    watchdog_set_restart_priority(&wdt->wdd, 128);
>>       wdt_setload(&wdt->wdd, DEFAULT_TIMEOUT);
>>         ret = watchdog_register_device(&wdt->wdd);
>>
>
>

      reply	other threads:[~2018-05-09  2:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-02  7:59 [PATCH v2] " Jongsung Kim
2018-05-02 13:21 ` Guenter Roeck
2018-05-04  6:05   ` [PATCH v3] " Jongsung Kim
2018-05-04 13:11     ` Guenter Roeck
2018-05-09  2:40       ` Jongsung Kim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6d09e8c6-d6b9-d0ea-2496-1b1cd1487808@lge.com \
    --to=neidhard.kim@lge.com \
    --cc=chanho.min@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=wim@linux-watchdog.org \
    --subject='Re: [PATCH v3] watchdog: sp805: add restart handler' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).