From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDA54C4CECE for ; Fri, 13 Mar 2020 17:29:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AE704206E9 for ; Fri, 13 Mar 2020 17:29:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727061AbgCMR3N (ORCPT ); Fri, 13 Mar 2020 13:29:13 -0400 Received: from mga04.intel.com ([192.55.52.120]:49216 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726534AbgCMR3N (ORCPT ); Fri, 13 Mar 2020 13:29:13 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Mar 2020 10:29:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,549,1574150400"; d="scan'208";a="237017311" Received: from sblancoa-mobl.amr.corp.intel.com (HELO [10.251.232.239]) ([10.251.232.239]) by fmsmga008.fm.intel.com with ESMTP; 13 Mar 2020 10:29:02 -0700 Subject: Re: [PATCH 05/16] soundwire: cadence: add clock_stop/restart routines To: Vinod Koul Cc: alsa-devel@alsa-project.org, tiwai@suse.de, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, Ranjani Sridharan , Hui Wang , broonie@kernel.org, srinivas.kandagatla@linaro.org, jank@cadence.com, slawomir.blauciak@intel.com, Sanyog Kale , Rander Wang , Bard liao , Rander Wang References: <20200311184128.4212-1-pierre-louis.bossart@linux.intel.com> <20200311184128.4212-6-pierre-louis.bossart@linux.intel.com> <20200313122156.GG4885@vkoul-mobl> From: Pierre-Louis Bossart Message-ID: <6d38a58a-a840-169a-1078-e10c278c11fd@linux.intel.com> Date: Fri, 13 Mar 2020 12:07:59 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200313122156.GG4885@vkoul-mobl> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/13/20 7:21 AM, Vinod Koul wrote: > On 11-03-20, 13:41, Pierre-Louis Bossart wrote: > >> @@ -225,12 +225,30 @@ static int cdns_clear_bit(struct sdw_cdns *cdns, int offset, u32 value) >> return 0; >> >> timeout--; >> - udelay(50); >> + usleep_range(50, 100); > > this seems okay change, but unrelated to this patch ok. It doesn't really matter anyway, this function is removed in Patch 8 >> +int sdw_cdns_clock_stop(struct sdw_cdns *cdns, bool block_wake) >> +{ >> + bool slave_present = false; >> + struct sdw_slave *slave; >> + u32 status; >> + int ret; >> + >> + /* Check suspend status */ >> + status = cdns_readl(cdns, CDNS_MCP_STAT); >> + if (status & CDNS_MCP_STAT_CLK_STOP) { >> + dev_dbg(cdns->dev, "Clock is already stopped\n"); >> + return 1; > > return of 1..? Does that indicate success/fail..? success. I guess it could be moved as 0. ret = sdw_cdns_clock_stop(cdns, true); if (ret < 0) { dev_err(dev, "cannot enable clock stop on suspend\n"); return ret; }