LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Rientjes <rientjes@google.com>
To: Luigi Rizzo <lrizzo@google.com>
Cc: Will Deacon <will@kernel.org>,
	linux-kernel@vger.kernel.org, Joerg Roedel <joro@8bytes.org>,
	rizzo.unipi@gmail.com,
	Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Subject: Re: [PATCH] amd/iommu: fix logic bug in amd_iommu_report_page_fault()
Date: Sun, 1 Aug 2021 20:52:42 -0700 (PDT)	[thread overview]
Message-ID: <6d9bf4fc-4956-70fd-6d80-2b0ee92a571@google.com> (raw)
In-Reply-To: <20210731192637.3653796-1-lrizzo@google.com>

On Sat, 31 Jul 2021, Luigi Rizzo wrote:

> amd_iommu_report_page_fault() has two print paths, depending on whether or
> not it can find a pci device. But the code erroneously enters the second
> path if the rate limiter in the first path triggers:
>   if (dev_data && ratelimit(A)) { A; } else if (ratelimit(B)) { B; }
> The correct code should be
>   if (dev_data) { if (ratelimit(A)) { A;} } else if (ratelimit(B)) { B; }
> 
> Signed-off-by: Luigi Rizzo <lrizzo@google.com>

Acked-by: David Rientjes <rientjes@google.com>

This would be very helpful so we don't erroneously classify these KERN_ERR 
messages as dangerous.

  reply	other threads:[~2021-08-02  3:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-31 19:26 Luigi Rizzo
2021-08-02  3:52 ` David Rientjes [this message]
2021-08-02 14:13 ` Joerg Roedel
2021-08-02 14:30   ` Luigi Rizzo
2021-08-02 14:38     ` Joerg Roedel
2021-08-02 15:26       ` Luigi Rizzo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6d9bf4fc-4956-70fd-6d80-2b0ee92a571@google.com \
    --to=rientjes@google.com \
    --cc=joro@8bytes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrizzo@google.com \
    --cc=rizzo.unipi@gmail.com \
    --cc=suravee.suthikulpanit@amd.com \
    --cc=will@kernel.org \
    --subject='Re: [PATCH] amd/iommu: fix logic bug in amd_iommu_report_page_fault()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).