LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH -next 0/2] Platform: OLPC: Fix two randbuild error
@ 2019-05-28  9:28 YueHaibing
  2019-05-28  9:28 ` [PATCH -next 1/2] Platform: OLPC: Fix build error without CONFIG_SPI YueHaibing
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: YueHaibing @ 2019-05-28  9:28 UTC (permalink / raw)
  To: dvhart, andy, lkundrak; +Cc: linux-kernel, platform-driver-x86, YueHaibing

Fix two randbuild error:
1) Fix build error with CONFIG_SPI is not set
2) Fix build error with CONFIG_INPUT is set to m

YueHaibing (2):
  Platform: OLPC: Fix build error without CONFIG_SPI
  Platform: OLPC: Add INPUT dependencies

 drivers/platform/olpc/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
2.7.4



^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH -next 1/2] Platform: OLPC: Fix build error without CONFIG_SPI
  2019-05-28  9:28 [PATCH -next 0/2] Platform: OLPC: Fix two randbuild error YueHaibing
@ 2019-05-28  9:28 ` YueHaibing
  2019-05-28  9:28 ` [PATCH -next 2/2] Platform: OLPC: Add INPUT dependencies YueHaibing
  2019-05-28 11:06 ` [PATCH -next 0/2] Platform: OLPC: Fix two randbuild error Lubomir Rintel
  2 siblings, 0 replies; 4+ messages in thread
From: YueHaibing @ 2019-05-28  9:28 UTC (permalink / raw)
  To: dvhart, andy, lkundrak; +Cc: linux-kernel, platform-driver-x86, YueHaibing

Fix gcc build error while CONFIG_SPI is not set

drivers/platform/olpc/olpc-xo175-ec.o: In function `olpc_xo175_ec_remove':
olpc-xo175-ec.c:(.text+0x190): undefined reference to `spi_slave_abort'
drivers/platform/olpc/olpc-xo175-ec.o: In function `olpc_xo175_ec_send_command':
olpc-xo175-ec.c:(.text+0x374): undefined reference to `spi_async'
drivers/platform/olpc/olpc-xo175-ec.o: In function `olpc_xo175_ec_cmd':
olpc-xo175-ec.c:(.text+0x8a0): undefined reference to `spi_slave_abort'
drivers/platform/olpc/olpc-xo175-ec.o: In function `olpc_xo175_ec_spi_driver_init':
olpc-xo175-ec.c:(.init.text+0x14): undefined reference to `__spi_register_driver'

We should depends on CONFIG_SPI_SLAVE other than directly select it.

Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: 0c3d931b3ab9 ("Platform: OLPC: Add XO-1.75 EC driver")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/platform/olpc/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/olpc/Kconfig b/drivers/platform/olpc/Kconfig
index 858ac1d..1d3244a 100644
--- a/drivers/platform/olpc/Kconfig
+++ b/drivers/platform/olpc/Kconfig
@@ -5,7 +5,7 @@ config OLPC_EC
 config OLPC_XO175_EC
 	tristate "OLPC XO 1.75 Embedded Controller"
 	depends on ARCH_MMP || COMPILE_TEST
-	select SPI_SLAVE
+	depends on SPI_SLAVE
 	select OLPC_EC
 	help
 	  Include support for the OLPC XO Embedded Controller (EC). The EC
-- 
2.7.4



^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH -next 2/2] Platform: OLPC: Add INPUT dependencies
  2019-05-28  9:28 [PATCH -next 0/2] Platform: OLPC: Fix two randbuild error YueHaibing
  2019-05-28  9:28 ` [PATCH -next 1/2] Platform: OLPC: Fix build error without CONFIG_SPI YueHaibing
@ 2019-05-28  9:28 ` YueHaibing
  2019-05-28 11:06 ` [PATCH -next 0/2] Platform: OLPC: Fix two randbuild error Lubomir Rintel
  2 siblings, 0 replies; 4+ messages in thread
From: YueHaibing @ 2019-05-28  9:28 UTC (permalink / raw)
  To: dvhart, andy, lkundrak; +Cc: linux-kernel, platform-driver-x86, YueHaibing

Building with CONFIG_INPUT set to m:

drivers/platform/olpc/olpc-xo175-ec.o: In function `olpc_xo175_ec_complete':
olpc-xo175-ec.c:(.text+0x75d): undefined reference to `input_event'
olpc-xo175-ec.c:(.text+0x76f): undefined reference to `input_event'
olpc-xo175-ec.c:(.text+0x787): undefined reference to `input_event'
olpc-xo175-ec.c:(.text+0x799): undefined reference to `input_event'
drivers/platform/olpc/olpc-xo175-ec.o: In function `olpc_xo175_ec_probe':
olpc-xo175-ec.c:(.text+0x8d5): undefined reference to `devm_input_allocate_device'
olpc-xo175-ec.c:(.text+0x910): undefined reference to `input_set_capability'
olpc-xo175-ec.c:(.text+0x91c): undefined reference to `input_register_device'

This patch add INPUT dependencies to fix this.

Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: 0c3d931b3ab9 ("Platform: OLPC: Add XO-1.75 EC driver")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/platform/olpc/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/platform/olpc/Kconfig b/drivers/platform/olpc/Kconfig
index 1d3244a..1fa676c 100644
--- a/drivers/platform/olpc/Kconfig
+++ b/drivers/platform/olpc/Kconfig
@@ -6,6 +6,7 @@ config OLPC_XO175_EC
 	tristate "OLPC XO 1.75 Embedded Controller"
 	depends on ARCH_MMP || COMPILE_TEST
 	depends on SPI_SLAVE
+	depends on INPUT
 	select OLPC_EC
 	help
 	  Include support for the OLPC XO Embedded Controller (EC). The EC
-- 
2.7.4



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH -next 0/2] Platform: OLPC: Fix two randbuild error
  2019-05-28  9:28 [PATCH -next 0/2] Platform: OLPC: Fix two randbuild error YueHaibing
  2019-05-28  9:28 ` [PATCH -next 1/2] Platform: OLPC: Fix build error without CONFIG_SPI YueHaibing
  2019-05-28  9:28 ` [PATCH -next 2/2] Platform: OLPC: Add INPUT dependencies YueHaibing
@ 2019-05-28 11:06 ` Lubomir Rintel
  2 siblings, 0 replies; 4+ messages in thread
From: Lubomir Rintel @ 2019-05-28 11:06 UTC (permalink / raw)
  To: YueHaibing, dvhart, andy; +Cc: linux-kernel, platform-driver-x86

On Tue, 2019-05-28 at 17:28 +0800, YueHaibing wrote:
> Fix two randbuild error:
> 1) Fix build error with CONFIG_SPI is not set
> 2) Fix build error with CONFIG_INPUT is set to m
> 
> YueHaibing (2):
>   Platform: OLPC: Fix build error without CONFIG_SPI
>   Platform: OLPC: Add INPUT dependencies
> 
>  drivers/platform/olpc/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Thanks. Both patches:

Reviewed-by: Lubomir Rintel <lkundrak@v3.sk>


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-05-28 11:06 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-28  9:28 [PATCH -next 0/2] Platform: OLPC: Fix two randbuild error YueHaibing
2019-05-28  9:28 ` [PATCH -next 1/2] Platform: OLPC: Fix build error without CONFIG_SPI YueHaibing
2019-05-28  9:28 ` [PATCH -next 2/2] Platform: OLPC: Add INPUT dependencies YueHaibing
2019-05-28 11:06 ` [PATCH -next 0/2] Platform: OLPC: Fix two randbuild error Lubomir Rintel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).