LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Byungchul Park <byungchul.park@lge.com>
To: paulmck@linux.vnet.ibm.com
Cc: jiangshanlai@gmail.com, josh@joshtriplett.org,
	rostedt@goodmis.org, mathieu.desnoyers@efficios.com,
	linux-kernel@vger.kernel.org, kernel-team@lge.com,
	joel@joelfernandes.org
Subject: Re: [RFC] rcu: Check the range of jiffies_till_xxx_fqs on setting them
Date: Fri, 1 Jun 2018 10:42:10 +0900	[thread overview]
Message-ID: <7054f182-2648-983d-3602-e69ea36f90f6@lge.com> (raw)
In-Reply-To: <20180531111742.GQ7063@linux.vnet.ibm.com>



On 2018-05-31 20:17, Paul E. McKenney wrote:
> On Thu, May 31, 2018 at 11:51:40AM +0900, Byungchul Park wrote:
>> On 2018-05-31 11:18, Byungchul Park wrote:
>>> On 2018-05-29 21:01, Paul E. McKenney wrote:
>>>
>>>> One approach would be to embed the kernel_params_ops structure inside
>>>> another structure containing the limits, then just have two structures.
>>>> Perhaps something like this already exists?  I don't see it right off,
>>>> but then again, I am not exactly an expert on module_param.
>>>>
>>>> Thoughts?
>>>
>>> Unfortunately, I couldn't find it. There might be no way to verify
>>> range of a variable except the way I did. Could you give your opinion
>>> about whether I should go on it?
>>
>> Like..
> 
> This looks reasonable to me.  Although you could make something that took
> ranges, that would be more code than what you have below, so what you

Exactly.

> have below is good.  Could you please resend as a patch with Signed-off-by
> and commit log?

Sure, I will. Thanks a lot Paul.

-- 
Thanks,
Byungchul

      reply	other threads:[~2018-06-01  1:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-29  7:23 Byungchul Park
2018-05-29 12:01 ` Paul E. McKenney
2018-05-30 13:06   ` Byungchul Park
2018-05-30 13:49     ` Paul E. McKenney
2018-05-31  1:27       ` Byungchul Park
2018-05-31  2:18   ` Byungchul Park
2018-05-31  2:51     ` Byungchul Park
2018-05-31 11:17       ` Paul E. McKenney
2018-06-01  1:42         ` Byungchul Park [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7054f182-2648-983d-3602-e69ea36f90f6@lge.com \
    --to=byungchul.park@lge.com \
    --cc=jiangshanlai@gmail.com \
    --cc=joel@joelfernandes.org \
    --cc=josh@joshtriplett.org \
    --cc=kernel-team@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=rostedt@goodmis.org \
    --subject='Re: [RFC] rcu: Check the range of jiffies_till_xxx_fqs on setting them' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).