From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5B9EC433EF for ; Tue, 14 Sep 2021 04:05:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 943836103B for ; Tue, 14 Sep 2021 04:05:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232174AbhINEGg (ORCPT ); Tue, 14 Sep 2021 00:06:36 -0400 Received: from mga04.intel.com ([192.55.52.120]:36676 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229567AbhINEGe (ORCPT ); Tue, 14 Sep 2021 00:06:34 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10106"; a="219993015" X-IronPort-AV: E=Sophos;i="5.85,291,1624345200"; d="scan'208";a="219993015" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Sep 2021 21:05:11 -0700 X-IronPort-AV: E=Sophos;i="5.85,291,1624345200"; d="scan'208";a="469905096" Received: from shao2-debian.sh.intel.com (HELO [10.239.13.11]) ([10.239.13.11]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Sep 2021 21:05:08 -0700 Subject: Re: [kbuild-all] Re: [dborkman:pr/bpf-cgrp 2/4] include/linux/cgroup-defs.h:771:70: warning: unused parameter 'skcd' To: Nathan Chancellor , Daniel Borkmann Cc: kernel test robot , llvm@lists.linux.dev, kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, alexei.starovoitov@gmail.com, andrii@kernel.org References: <202109110835.fBYQcLIG-lkp@intel.com> <89bba45c-d15c-88b7-0e32-9280cd4e4990@iogearbox.net> From: Rong Chen Message-ID: <70913cfb-060d-ac53-5bdf-79aff65f0f7f@intel.com> Date: Tue, 14 Sep 2021 12:05:06 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/14/21 2:00 AM, Nathan Chancellor wrote: > Hi Daniel, > > On Mon, Sep 13, 2021 at 05:19:26PM +0200, Daniel Borkmann wrote: >> [ +Philip ] >> >> On 9/11/21 2:38 AM, kernel test robot wrote: >>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/dborkman/bpf.git pr/bpf-cgrp >>> head: 5a6e78baee7515884b93a90c5d03db601bc9063a >>> commit: f36377d0c40cce0cdeaff50031c268bc640d94f0 [2/4] bpf, cgroups: Fix cgroup v2 fallback on v1/v2 mixed mode >>> config: i386-randconfig-r032-20210910 (attached as .config) >>> compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 261cbe98c38f8c1ee1a482fe76511110e790f58a) >>> reproduce (this is a W=1 build): >>> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross >>> chmod +x ~/bin/make.cross >>> # https://git.kernel.org/pub/scm/linux/kernel/git/dborkman/bpf.git/commit/?id=f36377d0c40cce0cdeaff50031c268bc640d94f0 >>> git remote add dborkman https://git.kernel.org/pub/scm/linux/kernel/git/dborkman/bpf.git >>> git fetch --no-tags dborkman pr/bpf-cgrp >>> git checkout f36377d0c40cce0cdeaff50031c268bc640d94f0 >>> # save the attached .config to linux build tree >>> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=i386 >>> >>> If you fix the issue, kindly add following tag as appropriate >>> Reported-by: kernel test robot >>> >>> All warnings (new ones prefixed by >>): >> Not sure how useful these warnings below are given it is quite conventional in the kernel >> to have some static inline helper which e.g. look: >> >> static inline int bla(struct foo *bar) >> { >> #ifdef CONFIG_ >> return ... /// do something with bar >> #else >> return 0; >> #endif >> } >> >> I presume consensus here is to ignore these given also the gazillion other cases in the >> kernel tree. In other words, goal on -Wunused-parameter for kernel would be to really >> only catch cases where a parameter is indeed in all cases unused and should be removed >> from the signature. > Unfortunately, it looks like you are getting bit by a tangential issue > here: > > https://lore.kernel.org/r/YSQE2f5teuvKLkON@Ryzen-9-3900X.localdomain/ > > The full include log: > > In file included from drivers/gpu/drm/i915/display/intel_dpll.c:7: > In file included from drivers/gpu/drm/i915/display/intel_de.h:9: > In file included from ./drivers/gpu/drm/i915/i915_drv.h:39: > In file included from ./include/linux/i2c.h:18: > In file included from ./include/linux/regulator/consumer.h:35: > In file included from ./include/linux/suspend.h:5: > In file included from ./include/linux/swap.h:9: > In file included from ./include/linux/memcontrol.h:13: > In file included from ./include/linux/cgroup.h:28: > In file included from ./include/linux/cgroup-defs.h:22: > In file included from ./include/linux/bpf-cgroup.h:5: > ./include/linux/bpf.h:770:61: warning: unused parameter 'prog' [-Wunused-parameter] > static inline int bpf_trampoline_link_prog(struct bpf_prog *prog, > ^ > ./include/linux/bpf.h:771:32: warning: unused parameter 'tr' [-Wunused-parameter] > struct bpf_trampoline *tr) > ^ > ... > > The fixes are here: > > https://lore.kernel.org/r/20210824022640.2170859-1-nathan@kernel.org/ > https://lore.kernel.org/r/20210824232237.2085342-1-nathan@kernel.org/ > > I will push to get these fixes accepted as quickly as possible. > > Philip, would it be possible for you guys to avoid sending reports for > i386 configurations that contain any of the following three > configurations for the time being? > > CONFIG_MCRUSOE=y > CONFIG_MEFFICEON=y > CONFIG_MCYRIXIII=y > > They are resulting in a lot of false positives, as I have linked above. Hi Nathan, Thanks for the advice, we have disabled these config. Best Regards, Rong Chen > > Cheers, > Nathan > _______________________________________________ > kbuild-all mailing list -- kbuild-all@lists.01.org > To unsubscribe send an email to kbuild-all-leave@lists.01.org