LKML Archive on
help / color / mirror / Atom feed
From: "Hartkopp, Oliver (K-EFE/E)" <>
To: <>
Cc: <>
Subject: Missing 'warned = 1' in your latest linux-2.6 commit
Date: Mon, 14 Jan 2008 13:58:01 +0100	[thread overview]
Message-ID: <71A66C381173F7418BA6E78EE9E33465AC02EC@vwagwox00011.vw.vwg> (raw)

Hi Len,

in two cases you just introduce the 'warned' variable but do not set
them to '1' after the printk() which is the intetion to print it just
one time. Namely in pnpacpi_parse_allocated_ioresource() and
pnpacpi_parse_allocated_memresource() the 'warned = 1' is missing.;a=commi

Even if it will vanish in 2.6.25 you should fix this new introduced
code. :-)


             reply	other threads:[~2008-01-14 13:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-14 12:58 Hartkopp, Oliver (K-EFE/E) [this message]
2008-01-14 17:43 ` [PATCH 2.6.24 please] pnpacpi: print resource shortage message only once (more) Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=71A66C381173F7418BA6E78EE9E33465AC02EC@vwagwox00011.vw.vwg \ \ \ \
    --subject='Re: Missing '\''warned = 1'\'' in your latest linux-2.6 commit' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).