LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* Missing 'warned = 1' in your latest linux-2.6 commit
@ 2008-01-14 12:58 Hartkopp, Oliver (K-EFE/E)
  2008-01-14 17:43 ` [PATCH 2.6.24 please] pnpacpi: print resource shortage message only once (more) Len Brown
  0 siblings, 1 reply; 2+ messages in thread
From: Hartkopp, Oliver (K-EFE/E) @ 2008-01-14 12:58 UTC (permalink / raw)
  To: len.brown; +Cc: linux-kernel

Hi Len,

in two cases you just introduce the 'warned' variable but do not set
them to '1' after the printk() which is the intetion to print it just
one time. Namely in pnpacpi_parse_allocated_ioresource() and
pnpacpi_parse_allocated_memresource() the 'warned = 1' is missing.

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commi
tdiff;h=66a21736defda339cd93a0e70c1120ab813640f6;hp=2c838197751db19d08a0
0e633e33dce23a69fb0c

Even if it will vanish in 2.6.25 you should fix this new introduced
code. :-)

Regards,
Oliver


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH 2.6.24 please] pnpacpi: print resource shortage message only once (more)
  2008-01-14 12:58 Missing 'warned = 1' in your latest linux-2.6 commit Hartkopp, Oliver (K-EFE/E)
@ 2008-01-14 17:43 ` Len Brown
  0 siblings, 0 replies; 2+ messages in thread
From: Len Brown @ 2008-01-14 17:43 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: Hartkopp, Oliver (K-EFE/E), linux-kernel

From: Len Brown <len.brown@intel.com>

Wups, previous patch was ineffective in 2 cases.
    
http://bugzilla.kernel.org/show_bug.cgi?id=9535
    
Signed-off-by: Len Brown <len.brown@intel.com>
---
Thanks for noticing, Oliver!

diff --git a/drivers/pnp/pnpacpi/rsparser.c b/drivers/pnp/pnpacpi/rsparser.c
index f7b8648..6b9840c 100644
--- a/drivers/pnp/pnpacpi/rsparser.c
+++ b/drivers/pnp/pnpacpi/rsparser.c
@@ -215,6 +215,7 @@ static void pnpacpi_parse_allocated_ioresource(struct pnp_resource_table *res,
 	} else if (!warned) {
 		printk(KERN_ERR "pnpacpi: exceeded the max number of IO "
 				"resources: %d \n", PNP_MAX_PORT);
+		warned = 1;
 	}
 }
 
@@ -242,6 +243,7 @@ static void pnpacpi_parse_allocated_memresource(struct pnp_resource_table *res,
 	} else if (!warned) {
 		printk(KERN_ERR "pnpacpi: exceeded the max number of mem "
 				"resources: %d\n", PNP_MAX_MEM);
+		warned = 1;
 	}
 }
 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-01-14 17:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-01-14 12:58 Missing 'warned = 1' in your latest linux-2.6 commit Hartkopp, Oliver (K-EFE/E)
2008-01-14 17:43 ` [PATCH 2.6.24 please] pnpacpi: print resource shortage message only once (more) Len Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).