From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751746AbeDEL4K (ORCPT ); Thu, 5 Apr 2018 07:56:10 -0400 Received: from fllnx209.ext.ti.com ([198.47.19.16]:34744 "EHLO fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751447AbeDEL4J (ORCPT ); Thu, 5 Apr 2018 07:56:09 -0400 Subject: Re: regression: twl4030 audio/clock stopped working in v4.16 From: Peter Ujfalusi To: "H. Nikolaus Schaller" CC: Discussions about the Letux Kernel , Tony Lindgren , Linux Kernel Mailing List , linux-omap References: <2E644641-82D1-40AB-B878-06066C91AC7A@goldelico.com> <3c615b51-f9f4-7267-cc2d-2a74184058a8@ti.com> Message-ID: <73408cb9-7765-98c4-c516-4acb8dfc9e60@ti.com> Date: Thu, 5 Apr 2018 14:56:15 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <3c615b51-f9f4-7267-cc2d-2a74184058a8@ti.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Nikolaus, On 2018-04-05 14:05, Peter Ujfalusi wrote: > Nikolaus, > > can you CC me also, I have almost missed this... > > On 2018-04-04 21:29, H. Nikolaus Schaller wrote: >> Hi Peter, >> I just noticed a problem in v4.16 kernels with twl4030 audio and vibra driver no longer working. >> >> Tracing it back shows that it already did appear in v4.16-rc1 and wasn't fixed up to v4.16.0. >> Kernel v4.15.9 (the latest one where I have a binary) works. > > v4.16 works just fine on beagle-xm (including audio), omap2plus_defconfig. > >> The symptoms are: >> >> [ 1.557342] twl4030-audio 48070000.i2c:twl@48:audio: Invalid audio_mclk >> [ 1.564788] twl4030-audio: probe of 48070000.i2c:twl@48:audio failed with error -22 >> [ 1.839141] TWL4030: HFCLK is not configured > > Hrm, the order looks a bit weird, it should be > TWL4030: HFCLK is not configured > twl4030-audio 48070000.i2c:twl@48:audio: Invalid audio_mclk > twl4030-audio: probe of 48070000.i2c:twl@48:audio failed with error -22 > > In twl4030_audio_probe() we try to get the HFCLK rate via > twl_get_hfclk_rate(), which is reading it with: > twl_i2c_read_u8(TWL_MODULE_PM_MASTER, &ctrl, R_CFG_BOOT); > >> Those are not visible in v4.15.9. And I am not aware of any changes to the gta04 device tree. >> >> Do you know about this issue and a fix, before I start to bisect? > > The CFG_BOOT register of twl4030 is not configured correctly for some > reason? > The TRM of twl4030 states that the SW should program the HFCLK_FREQ > during boot sequence. > > If it is not done, MDAC and USB should not work either. And all sorts of > other issues might happen. > > So the boot loader is not configuring the HFCLK_FREQ, for me it does as > I have this line in the kernel log: > [ 1.472503] Skipping twl internal clock init and using bootloader > value (unknown osc rate) > > In DT the twl should have the fck clock to not depend on the bootloader > for the HFCLK_FREQ settings. We do not have that for beagle-xm for sure. there is a bug in twl-core for getting the clock: https://marc.info/?l=linux-omap&m=152292879928720&w=2 and a patch for beagle-xm to add the fixed clock: https://marc.info/?l=linux-omap&m=152292917328832&w=2 With these two, beagle-xm no longer depends on bootloader to set the HFCLK_FREQ for twl4030. - Péter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki