LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Jonathan Toppins <jtoppins@redhat.com>, netdev@vger.kernel.org
Cc: Jay Vosburgh <j.vosburgh@gmail.com>,
	Veaceslav Falico <vfalico@gmail.com>,
	Andy Gospodarek <andy@greyhouse.net>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] bonding: combine netlink and console error messages
Date: Sun, 08 Aug 2021 03:02:35 -0700	[thread overview]
Message-ID: <745ab8a85430ad4268a86b0957aa690c1a7a6d0f.camel@perches.com> (raw)
In-Reply-To: <f519f9eb-aefd-4d0a-01ce-4ed37b7930ef@redhat.com>

On Sat, 2021-08-07 at 17:54 -0400, Jonathan Toppins wrote:
> On 8/6/21 11:52 PM, Joe Perches wrote:
> > On Fri, 2021-08-06 at 23:30 -0400, Jonathan Toppins wrote:
> > > There seems to be no reason to have different error messages between
> > > netlink and printk. It also cleans up the function slightly.
> > []
> > > diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
> > []
> > > +#define BOND_NL_ERR(bond_dev, extack, errmsg) do {		\
> > > +	NL_SET_ERR_MSG(extack, errmsg);				\
> > > +	netdev_err(bond_dev, "Error: " errmsg "\n");		\
> > > +} while (0)
> > > +
> > > +#define SLAVE_NL_ERR(bond_dev, slave_dev, extack, errmsg) do {	\
> > > +	NL_SET_ERR_MSG(extack, errmsg);				\
> > > +	slave_err(bond_dev, slave_dev, "Error: " errmsg "\n");	\
> > > +} while (0)
> > 
> > If you are doing this, it's probably smaller object code to use
> > 	"%s", errmsg
> > as the errmsg string can be reused
> > 
> > #define BOND_NL_ERR(bond_dev, extack, errmsg)			\
> > do {								\
> > 	NL_SET_ERR_MSG(extack, errmsg);				\
> > 	netdev_err(bond_dev, "Error: %s\n", errmsg);		\
> > } while (0)
> > 
> > #define SLAVE_NL_ERR(bond_dev, slave_dev, extack, errmsg)	\
> > do {								\
> > 	NL_SET_ERR_MSG(extack, errmsg);				\
> > 	slave_err(bond_dev, slave_dev, "Error: %s\n", errmsg);	\
> > } while (0)
> > 
> > 
> 
> I like the thought and would agree if not for how NL_SET_ERR_MSG is 
> coded. Unfortunately it does not appear as though doing the above change 
> actually generates smaller object code. Maybe I have incorrectly 
> interpreted something?

No, it's because you are compiling allyesconfig or equivalent.
Try defconfig with bonding.



  reply	other threads:[~2021-08-08 10:08 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1628306392.git.jtoppins@redhat.com>
2021-08-07  3:30 ` [PATCH net-next 1/2] bonding: remove extraneous definitions from bonding.h Jonathan Toppins
2021-08-07  3:30 ` [PATCH net-next 2/2] bonding: combine netlink and console error messages Jonathan Toppins
2021-08-07  3:52   ` Joe Perches
2021-08-07 21:54     ` Jonathan Toppins
2021-08-08 10:02       ` Joe Perches [this message]
2021-08-09  2:07         ` Jonathan Toppins
2021-08-09  5:05           ` Joe Perches
2021-08-09 17:17             ` Jonathan Toppins
2021-08-08 10:16   ` Leon Romanovsky
2021-08-09  1:42     ` Jonathan Toppins
2021-08-09  6:03       ` Leon Romanovsky
2021-08-10  6:40   ` [PATCH net-next v2 " Jonathan Toppins
2021-08-10  6:47     ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=745ab8a85430ad4268a86b0957aa690c1a7a6d0f.camel@perches.com \
    --to=joe@perches.com \
    --cc=andy@greyhouse.net \
    --cc=davem@davemloft.net \
    --cc=j.vosburgh@gmail.com \
    --cc=jtoppins@redhat.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=vfalico@gmail.com \
    --subject='Re: [PATCH net-next 2/2] bonding: combine netlink and console error messages' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).