From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751495AbeD1TbO (ORCPT ); Sat, 28 Apr 2018 15:31:14 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:39808 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751334AbeD1TbM (ORCPT ); Sat, 28 Apr 2018 15:31:12 -0400 X-Google-Smtp-Source: AB8JxZpLEdMzCsXSfZ4KHfwxKEXy9AlPiRilBJTgorwDpJJoB/40KwfsgeI7MLxkrY4EN2Ng3unwLg== Subject: Re: [PATCH v2 0/3] Rework write error handling in pblk To: Hans Holmberg Cc: linux-block@vger.kernel.org, Javier Gonzales , linux-kernel@vger.kernel.org, Hans Holmberg References: <1524548732-4326-1-git-send-email-hans.ml.holmberg@owltronix.com> From: =?UTF-8?Q?Matias_Bj=c3=b8rling?= Message-ID: <7536f5dc-bc11-ae4b-b11e-9c3995142cd0@lightnvm.io> Date: Sat, 28 Apr 2018 12:31:08 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <1524548732-4326-1-git-send-email-hans.ml.holmberg@owltronix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/23/18 10:45 PM, Hans Holmberg wrote: > From: Hans Holmberg > > This patch series fixes the(currently incomplete) write error handling > in pblk by: > > * queuing and re-submitting failed writes in the write buffer > * evacuating valid data data in lines with write failures, so the > chunk(s) with write failures can be reset to a known state by the fw > > Lines with failures in smeta are put back on the free list. > Failed chunks will be reset on the next use. > > If a write failes in emeta, the lba list is cached so the line can be > garbage collected without scanning the out-of-band area. > > Changes in V2: > - Added the recov_writes counter increase to the new path > - Moved lba list emeta reading during gc to a separate function > - Allocating the saved lba list with pblk_malloc instead of kmalloc > - Fixed formatting issues > - Removed dead code > > Hans Holmberg (3): > lightnvm: pblk: rework write error recovery path > lightnvm: pblk: garbage collect lines with failed writes > lightnvm: pblk: fix smeta write error path > > drivers/lightnvm/pblk-core.c | 52 +++++++- > drivers/lightnvm/pblk-gc.c | 102 +++++++++------ > drivers/lightnvm/pblk-init.c | 47 ++++--- > drivers/lightnvm/pblk-rb.c | 39 ------ > drivers/lightnvm/pblk-recovery.c | 91 ------------- > drivers/lightnvm/pblk-rl.c | 29 ++++- > drivers/lightnvm/pblk-sysfs.c | 15 ++- > drivers/lightnvm/pblk-write.c | 269 ++++++++++++++++++++++++++------------- > drivers/lightnvm/pblk.h | 36 ++++-- > 9 files changed, 384 insertions(+), 296 deletions(-) > Thanks Hans. I've applied 1 & 3. The second did not apply cleanly to for-4.18/core. Could you please resend a rebased version?