LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] ASoC: dt-bindings: lpass: add binding headers for digital codecs
@ 2021-09-06 13:27 Srinivasa Rao Mandadapu
  2021-09-07 20:24 ` Stephen Boyd
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Srinivasa Rao Mandadapu @ 2021-09-06 13:27 UTC (permalink / raw)
  To: agross, bjorn.andersson, lgirdwood, broonie, robh+dt, plai,
	bgoswami, perex, tiwai, srinivas.kandagatla, rohitkr,
	linux-arm-msm, alsa-devel, devicetree, linux-kernel, swboyd,
	judyhsiao
  Cc: Srinivasa Rao Mandadapu

Add header defining for lpass internal digital codecs rx,tx and va
dai node id's.

Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org>
---
 include/dt-bindings/sound/qcom,lpass.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/include/dt-bindings/sound/qcom,lpass.h b/include/dt-bindings/sound/qcom,lpass.h
index 7b0b80b..187af45 100644
--- a/include/dt-bindings/sound/qcom,lpass.h
+++ b/include/dt-bindings/sound/qcom,lpass.h
@@ -10,6 +10,11 @@
 
 #define LPASS_DP_RX	5
 
+#define LPASS_CDC_DMA_RX0 6
+#define LPASS_CDC_DMA_TX3 7
+#define LPASS_CDC_DMA_VA0 8
+#define LPASS_MAX_PORTS 9
+
 #define LPASS_MCLK0	0
 
 #endif /* __DT_QCOM_LPASS_H */
-- 
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] ASoC: dt-bindings: lpass: add binding headers for digital codecs
  2021-09-06 13:27 [PATCH] ASoC: dt-bindings: lpass: add binding headers for digital codecs Srinivasa Rao Mandadapu
@ 2021-09-07 20:24 ` Stephen Boyd
  2021-09-08  4:38   ` Srinivasa Rao Mandadapu
  2021-09-08  9:41 ` Srinivas Kandagatla
  2021-09-13 10:53 ` Mark Brown
  2 siblings, 1 reply; 8+ messages in thread
From: Stephen Boyd @ 2021-09-07 20:24 UTC (permalink / raw)
  To: Srinivasa Rao Mandadapu, agross, alsa-devel, bgoswami,
	bjorn.andersson, broonie, devicetree, judyhsiao, lgirdwood,
	linux-arm-msm, linux-kernel, perex, plai, robh+dt, rohitkr,
	srinivas.kandagatla, tiwai

Quoting Srinivasa Rao Mandadapu (2021-09-06 06:27:34)
> Add header defining for lpass internal digital codecs rx,tx and va
> dai node id's.
>
> Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org>
> ---
>  include/dt-bindings/sound/qcom,lpass.h | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/include/dt-bindings/sound/qcom,lpass.h b/include/dt-bindings/sound/qcom,lpass.h
> index 7b0b80b..187af45 100644
> --- a/include/dt-bindings/sound/qcom,lpass.h
> +++ b/include/dt-bindings/sound/qcom,lpass.h
> @@ -10,6 +10,11 @@
>
>  #define LPASS_DP_RX    5
>
> +#define LPASS_CDC_DMA_RX0 6
> +#define LPASS_CDC_DMA_TX3 7
> +#define LPASS_CDC_DMA_VA0 8
> +#define LPASS_MAX_PORTS 9

Do we need LPASS_MAX_PORTS in the binding?

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] ASoC: dt-bindings: lpass: add binding headers for digital codecs
  2021-09-07 20:24 ` Stephen Boyd
@ 2021-09-08  4:38   ` Srinivasa Rao Mandadapu
  2021-09-08 10:23     ` Mark Brown
  0 siblings, 1 reply; 8+ messages in thread
From: Srinivasa Rao Mandadapu @ 2021-09-08  4:38 UTC (permalink / raw)
  To: Stephen Boyd, agross, alsa-devel, bgoswami, bjorn.andersson,
	broonie, devicetree, judyhsiao, lgirdwood, linux-arm-msm,
	linux-kernel, perex, plai, robh+dt, rohitkr, srinivas.kandagatla,
	tiwai

Thanks For Review Stephen!!!

On 9/8/2021 1:54 AM, Stephen Boyd wrote:
> Quoting Srinivasa Rao Mandadapu (2021-09-06 06:27:34)
>> Add header defining for lpass internal digital codecs rx,tx and va
>> dai node id's.
>>
>> Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org>
>> ---
>>   include/dt-bindings/sound/qcom,lpass.h | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/include/dt-bindings/sound/qcom,lpass.h b/include/dt-bindings/sound/qcom,lpass.h
>> index 7b0b80b..187af45 100644
>> --- a/include/dt-bindings/sound/qcom,lpass.h
>> +++ b/include/dt-bindings/sound/qcom,lpass.h
>> @@ -10,6 +10,11 @@
>>
>>   #define LPASS_DP_RX    5
>>
>> +#define LPASS_CDC_DMA_RX0 6
>> +#define LPASS_CDC_DMA_TX3 7
>> +#define LPASS_CDC_DMA_VA0 8
>> +#define LPASS_MAX_PORTS 9
> Do we need LPASS_MAX_PORTS in the binding?
Yes.  based on this creating array of streams in machine driver. So to 
make upper limit introduced this macro.

-- 
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] ASoC: dt-bindings: lpass: add binding headers for digital codecs
  2021-09-06 13:27 [PATCH] ASoC: dt-bindings: lpass: add binding headers for digital codecs Srinivasa Rao Mandadapu
  2021-09-07 20:24 ` Stephen Boyd
@ 2021-09-08  9:41 ` Srinivas Kandagatla
  2021-09-08 13:05   ` Srinivasa Rao Mandadapu
  2021-09-13 10:53 ` Mark Brown
  2 siblings, 1 reply; 8+ messages in thread
From: Srinivas Kandagatla @ 2021-09-08  9:41 UTC (permalink / raw)
  To: Srinivasa Rao Mandadapu, agross, bjorn.andersson, lgirdwood,
	broonie, robh+dt, plai, bgoswami, perex, tiwai, rohitkr,
	linux-arm-msm, alsa-devel, devicetree, linux-kernel, swboyd,
	judyhsiao



On 06/09/2021 14:27, Srinivasa Rao Mandadapu wrote:
> +#define LPASS_CDC_DMA_RX0 6

You are only adding RX0, what happens to RX1.. RX7

TBH, skipping other entries for ex CDC_DMA_RX will end up with sparse 
numbering.

Please add all the entries for CDC_DMA_RX and other ports as well.

Like:

#define LPASS_CDC_DMA_RX0	6
#define LPASS_CDC_DMA_RX1	7
#define LPASS_CDC_DMA_RX2	8
#define LPASS_CDC_DMA_RX3	9
#define LPASS_CDC_DMA_RX4	10
#define LPASS_CDC_DMA_RX5	11
#define LPASS_CDC_DMA_RX6	12
#define LPASS_CDC_DMA_RX7	13


> +#define LPASS_CDC_DMA_TX3 7
> +#define LPASS_CDC_DMA_VA0 8
You mean VA_TX0?


> +#define LPASS_MAX_PORTS 9
We really do not need this in bindings.
You could add this is some of the driver header files instead.

--srini
> +

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] ASoC: dt-bindings: lpass: add binding headers for digital codecs
  2021-09-08  4:38   ` Srinivasa Rao Mandadapu
@ 2021-09-08 10:23     ` Mark Brown
  2021-09-08 13:06       ` Srinivasa Rao Mandadapu
  0 siblings, 1 reply; 8+ messages in thread
From: Mark Brown @ 2021-09-08 10:23 UTC (permalink / raw)
  To: Srinivasa Rao Mandadapu
  Cc: Stephen Boyd, agross, alsa-devel, bgoswami, bjorn.andersson,
	devicetree, judyhsiao, lgirdwood, linux-arm-msm, linux-kernel,
	perex, plai, robh+dt, rohitkr, srinivas.kandagatla, tiwai

[-- Attachment #1: Type: text/plain, Size: 516 bytes --]

On Wed, Sep 08, 2021 at 10:08:33AM +0530, Srinivasa Rao Mandadapu wrote:
> On 9/8/2021 1:54 AM, Stephen Boyd wrote:
> > Quoting Srinivasa Rao Mandadapu (2021-09-06 06:27:34)

> > > +#define LPASS_CDC_DMA_VA0 8
> > > +#define LPASS_MAX_PORTS 9

> > Do we need LPASS_MAX_PORTS in the binding?

> Yes.  based on this creating array of streams in machine driver. So to make
> upper limit introduced this macro.

That's saying it's useful to have it in the code, do we need it in the
binding itself though?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] ASoC: dt-bindings: lpass: add binding headers for digital codecs
  2021-09-08  9:41 ` Srinivas Kandagatla
@ 2021-09-08 13:05   ` Srinivasa Rao Mandadapu
  0 siblings, 0 replies; 8+ messages in thread
From: Srinivasa Rao Mandadapu @ 2021-09-08 13:05 UTC (permalink / raw)
  To: Srinivas Kandagatla, agross, bjorn.andersson, lgirdwood, broonie,
	robh+dt, plai, bgoswami, perex, tiwai, rohitkr, linux-arm-msm,
	alsa-devel, devicetree, linux-kernel, swboyd, judyhsiao

Thanks for your time and valuable suggestions Srini!!

On 9/8/2021 3:11 PM, Srinivas Kandagatla wrote:
>
>
> On 06/09/2021 14:27, Srinivasa Rao Mandadapu wrote:
>> +#define LPASS_CDC_DMA_RX0 6
>
> You are only adding RX0, what happens to RX1.. RX7
>
> TBH, skipping other entries for ex CDC_DMA_RX will end up with sparse 
> numbering.
>
> Please add all the entries for CDC_DMA_RX and other ports as well.
>
> Like:
>
> #define LPASS_CDC_DMA_RX0    6
> #define LPASS_CDC_DMA_RX1    7
> #define LPASS_CDC_DMA_RX2    8
> #define LPASS_CDC_DMA_RX3    9
> #define LPASS_CDC_DMA_RX4    10
> #define LPASS_CDC_DMA_RX5    11
> #define LPASS_CDC_DMA_RX6    12
> #define LPASS_CDC_DMA_RX7    13
>
>
Okay. Will add and Share new patch.
>> +#define LPASS_CDC_DMA_TX3 7
>> +#define LPASS_CDC_DMA_VA0 8
> You mean VA_TX0?
>
Yes. Will change accordingly.
>
>> +#define LPASS_MAX_PORTS 9
> We really do not need this in bindings.
> You could add this is some of the driver header files instead.
>
Okay Will remove.
> --srini
>> +

-- 
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] ASoC: dt-bindings: lpass: add binding headers for digital codecs
  2021-09-08 10:23     ` Mark Brown
@ 2021-09-08 13:06       ` Srinivasa Rao Mandadapu
  0 siblings, 0 replies; 8+ messages in thread
From: Srinivasa Rao Mandadapu @ 2021-09-08 13:06 UTC (permalink / raw)
  To: Mark Brown
  Cc: Stephen Boyd, agross, alsa-devel, bgoswami, bjorn.andersson,
	devicetree, judyhsiao, lgirdwood, linux-arm-msm, linux-kernel,
	perex, plai, robh+dt, rohitkr, srinivas.kandagatla, tiwai

Thanks for Your Time Mark Brown!!!

On 9/8/2021 3:53 PM, Mark Brown wrote:
> On Wed, Sep 08, 2021 at 10:08:33AM +0530, Srinivasa Rao Mandadapu wrote:
>> On 9/8/2021 1:54 AM, Stephen Boyd wrote:
>>> Quoting Srinivasa Rao Mandadapu (2021-09-06 06:27:34)
>>>> +#define LPASS_CDC_DMA_VA0 8
>>>> +#define LPASS_MAX_PORTS 9
>>> Do we need LPASS_MAX_PORTS in the binding?
>> Yes.  based on this creating array of streams in machine driver. So to make
>> upper limit introduced this macro.
> That's saying it's useful to have it in the code, do we need it in the
> binding itself though?
Okay.  Got it. will remove it and share new patch.

-- 
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] ASoC: dt-bindings: lpass: add binding headers for digital codecs
  2021-09-06 13:27 [PATCH] ASoC: dt-bindings: lpass: add binding headers for digital codecs Srinivasa Rao Mandadapu
  2021-09-07 20:24 ` Stephen Boyd
  2021-09-08  9:41 ` Srinivas Kandagatla
@ 2021-09-13 10:53 ` Mark Brown
  2 siblings, 0 replies; 8+ messages in thread
From: Mark Brown @ 2021-09-13 10:53 UTC (permalink / raw)
  To: perex, plai, linux-kernel, srinivas.kandagatla, alsa-devel,
	bgoswami, bjorn.andersson, rohitkr, robh+dt, lgirdwood,
	devicetree, agross, tiwai, linux-arm-msm, swboyd,
	Srinivasa Rao Mandadapu, judyhsiao
  Cc: Mark Brown

On Mon, 6 Sep 2021 18:57:34 +0530, Srinivasa Rao Mandadapu wrote:
> Add header defining for lpass internal digital codecs rx,tx and va
> dai node id's.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: dt-bindings: lpass: add binding headers for digital codecs
      commit: bfad37c53ae6168d03ab06868ea44e77995c43d5

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2021-09-13 10:54 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-06 13:27 [PATCH] ASoC: dt-bindings: lpass: add binding headers for digital codecs Srinivasa Rao Mandadapu
2021-09-07 20:24 ` Stephen Boyd
2021-09-08  4:38   ` Srinivasa Rao Mandadapu
2021-09-08 10:23     ` Mark Brown
2021-09-08 13:06       ` Srinivasa Rao Mandadapu
2021-09-08  9:41 ` Srinivas Kandagatla
2021-09-08 13:05   ` Srinivasa Rao Mandadapu
2021-09-13 10:53 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).