LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Jin, Yao" <yao.jin@linux.intel.com>
To: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
Cc: jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com,
	alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org,
	ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH v3 0/2] perf report: Support annotation of code without symbols
Date: Thu, 27 Feb 2020 22:47:33 +0800	[thread overview]
Message-ID: <75e68b18-1a84-ec76-7672-f386dbe51a3e@linux.intel.com> (raw)
In-Reply-To: <20200227135023.GD10761@kernel.org>



On 2/27/2020 9:50 PM, Arnaldo Carvalho de Melo wrote:
> Em Mon, Feb 24, 2020 at 10:22:23AM +0800, Jin Yao escreveu:
>> For perf report on stripped binaries it is currently impossible to do
>> annotation. The annotation state is all tied to symbols, but there are
>> either no symbols, or symbols are not covering all the code.
>>
>> We should support the annotation functionality even without symbols.
>>
>> The first patch uses al_addr to print because it's easy to dump
>> the instructions from this address in binary for branch mode.
>>
>> The second patch supports the annotation on stripped binary.
> 
> I'm considering this a new feature, so I'll leave this for perf/core,
> i.e. for the next release, ok?
> 

Yes, it's a new feature, so perf/core branch is OK. Thanks! :)

BTW, v3 is old, I just post v5 according to Jiri's comments.

> I'm now going thru the pure fixes that should go to perf/urgent, please
> holler if something you think should go in now is not in my perf/urgent
> branch.
>  > - Arnaldo
>

In summary, I have some patch series waiting but I think they can be in 
perf/core.

https://lkml.org/lkml/2020/2/2/83
https://lkml.org/lkml/2020/2/14/136
https://lkml.org/lkml/2020/2/19/1274
https://lkml.org/lkml/2020/2/26/1348

Following is a fix, maybe it can be in perf/urgent.

"perf stat: Align the output for interval aggregation mode"
https://lkml.org/lkml/2020/2/20/321

Thanks
Jin Yao

>>   v3:
>>   ---
>>   Keep just the ANNOTATION_DUMMY_LEN, and remove the
>>   opts->annotate_dummy_len since it's the "maybe in future
>>   we will provide" feature.
>>
>>   v2:
>>   ---
>>   Fix a crash issue when annotating an address in "unknown" object.
>>
>> Jin Yao (2):
>>    perf util: Print al_addr when symbol is not found
>>    Support interactive annotation of code without symbols
>>
>>   tools/perf/ui/browsers/hists.c | 43 +++++++++++++++++++++++++++++-----
>>   tools/perf/util/annotate.h     |  1 +
>>   tools/perf/util/sort.c         |  6 +++--
>>   3 files changed, 42 insertions(+), 8 deletions(-)
>>
>> -- 
>> 2.17.1
>>
> 

      reply	other threads:[~2020-02-27 14:47 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-24  2:22 Jin Yao
2020-02-24  2:22 ` [PATCH v3 1/2] perf util: Print al_addr when symbol is not found Jin Yao
2020-02-24  2:22 ` [PATCH v3 2/2] Support interactive annotation of code without symbols Jin Yao
2020-02-24 12:35   ` Jiri Olsa
2020-02-24 15:39     ` Jin, Yao
2020-02-24 20:46       ` Jiri Olsa
2020-02-24 13:25   ` Ravi Bangoria
2020-02-24 13:51     ` Jiri Olsa
2020-02-24 14:04       ` Ravi Bangoria
2020-02-24 15:53         ` Jin, Yao
2020-02-24 15:44     ` Jin, Yao
2020-02-24 13:56   ` Ravi Bangoria
2020-02-24 15:46     ` Jin, Yao
2020-02-27 13:50 ` [PATCH v3 0/2] perf report: Support " Arnaldo Carvalho de Melo
2020-02-27 14:47   ` Jin, Yao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=75e68b18-1a84-ec76-7672-f386dbe51a3e@linux.intel.com \
    --to=yao.jin@linux.intel.com \
    --cc=Linux-kernel@vger.kernel.org \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=arnaldo.melo@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@intel.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=yao.jin@intel.com \
    --subject='Re: [PATCH v3 0/2] perf report: Support annotation of code without symbols' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).