LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Chunfeng Yun (云春峰)" <Chunfeng.Yun@mediatek.com>
To: "ikjn@chromium.org" <ikjn@chromium.org>
Cc: "linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"mathias.nyman@intel.com" <mathias.nyman@intel.com>,
	"Eddie Hung (洪正鑫)" <Eddie.Hung@mediatek.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>
Subject: Re: [PATCH 09/11] usb: xhci-mtk: check boundary before check tt
Date: Wed, 11 Aug 2021 08:18:02 +0000	[thread overview]
Message-ID: <75f8dd3285046fa85e10b776c758b23b1f408a24.camel@mediatek.com> (raw)
In-Reply-To: <CAATdQgA4qwKb=Uee1pUj-Fk8G31zA40OD7o49W1YLUhZh7BHWA@mail.gmail.com>

On Mon, 2021-08-09 at 15:32 +0800, Ikjoon Jang wrote:
> Hi Chunfeng,
> 
> On Fri, Jul 30, 2021 at 4:50 PM Chunfeng Yun <
> chunfeng.yun@mediatek.com> wrote:
> > 
> > check_sch_tt() will access fs_bus_bw[] array, check boundary
> > firstly to avoid out-of-bounds issue.
> > 
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > ---
> >  drivers/usb/host/xhci-mtk-sch.c | 7 ++++---
> >  1 file changed, 4 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/usb/host/xhci-mtk-sch.c
> > b/drivers/usb/host/xhci-mtk-sch.c
> > index 10c0f0f6461f..c2f13d69c607 100644
> > --- a/drivers/usb/host/xhci-mtk-sch.c
> > +++ b/drivers/usb/host/xhci-mtk-sch.c
> > @@ -600,13 +600,14 @@ static int check_sch_bw(struct
> > mu3h_sch_bw_info *sch_bw,
> >          * and find a microframe where its worst bandwidth is
> > minimum.
> >          */
> >         for (offset = 0; offset < sch_ep->esit; offset++) {
> > -               ret = check_sch_tt(sch_ep, offset);
> > -               if (ret)
> > -                       continue;
> > 
> >                 if ((offset + sch_ep->num_budget_microframes) >
> > esit_boundary)
> >                         break;
> 
> Instead of dropping it,
> I'm wondering if it should be checked against (offset & 63) == 0 when
> it's 64?
No, sch_ep->esit already ensure it, it's <= 64, see get_esit()

> 
> > 
> > +               ret = check_sch_tt(sch_ep, offset);
> > +               if (ret)
> > +                       continue;
> > +
> >                 worst_bw = get_max_bw(sch_bw, sch_ep, offset);
> >                 if (worst_bw > bw_boundary)
> >                         continue;
> > --
> > 2.18.0
> > 

  reply	other threads:[~2021-08-11  8:18 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-30  8:49 [PATCH 01/11] dt-bindings: usb: mtk-xhci: add support property 'tpl-support' Chunfeng Yun
2021-07-30  8:49 ` [PATCH 02/11] dt-bindings: usb: mtk-xhci: add optional property to disable usb2 ports Chunfeng Yun
2021-08-06 20:41   ` Rob Herring
2021-08-11  8:12     ` Chunfeng Yun (云春峰)
2021-07-30  8:49 ` [PATCH 03/11] dt-bindings: usb: mtk-xhci: add compatible for mt8195 Chunfeng Yun
2021-08-06 20:43   ` Rob Herring
2021-08-11  8:02     ` Chunfeng Yun (云春峰)
2021-08-18 14:20       ` Rob Herring
2021-08-19 11:36         ` Chunfeng Yun (云春峰)
2021-07-30  8:49 ` [PATCH 04/11] usb: xhci-mtk: fix use-after-free of mtk->hcd Chunfeng Yun
2021-08-13  5:26   ` Ikjoon Jang
2021-07-30  8:49 ` [PATCH 05/11] usb: xhci-mtk: add support 'tpl-support' Chunfeng Yun
2021-07-30  8:49 ` [PATCH 06/11] usb: xhci-mtk: support option to disable usb2 ports Chunfeng Yun
2021-07-30  8:49 ` [PATCH 07/11] usb: xhci-mtk: fix issue of out-of-bounds array access Chunfeng Yun
2021-07-30  8:49 ` [PATCH 08/11] usb: xhci-mtk: update fs bus bandwidth by bw_budget_table Chunfeng Yun
2021-08-03  6:05   ` Ikjoon Jang
2021-08-04  5:19     ` Chunfeng Yun
2021-08-04 14:06       ` Ikjoon Jang
2021-08-10  1:45         ` Chunfeng Yun (云春峰)
2021-07-30  8:50 ` [PATCH 09/11] usb: xhci-mtk: check boundary before check tt Chunfeng Yun
2021-08-09  7:32   ` Ikjoon Jang
2021-08-11  8:18     ` Chunfeng Yun (云春峰) [this message]
2021-07-30  8:50 ` [PATCH 10/11] usb: xhci-mtk: add a member of num_esit Chunfeng Yun
2021-07-30  8:50 ` [PATCH 11/11] usb: xhci-mtk: modify the SOF/ITP interval for mt8195 Chunfeng Yun
2021-08-06 20:37 ` [PATCH 01/11] dt-bindings: usb: mtk-xhci: add support property 'tpl-support' Rob Herring
2021-08-11  7:54   ` Chunfeng Yun (云春峰)
2021-08-12  2:28   ` Chunfeng Yun (云春峰)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=75f8dd3285046fa85e10b776c758b23b1f408a24.camel@mediatek.com \
    --to=chunfeng.yun@mediatek.com \
    --cc=Eddie.Hung@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=ikjn@chromium.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    --cc=matthias.bgg@gmail.com \
    --cc=robh+dt@kernel.org \
    --subject='Re: [PATCH 09/11] usb: xhci-mtk: check boundary before check tt' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).