LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Andrew Paprocki" <andrew@ishiboo.com>
To: "Oliver Schuster" <oliver.s@inbox.com>
Cc: "Wim Van Sebroeck" <wim@iguana.be>,
	"Oliver Schuster" <olivers137@aol.com>,
	"Linus Torvalds" <torvalds@linux-foundation.org>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][WATCHDOG] v2.6.25-rc7: it8712f_wdt.c contains an error - was Re: [WATCHDOG] v2.5.25-rc patches
Date: Tue, 1 Apr 2008 11:27:04 -0400	[thread overview]
Message-ID: <76366b180804010827r3a8094c6kae46bc3d629eccc9@mail.gmail.com> (raw)
In-Reply-To: <47F24F6D.6000603@inbox.com>

Oliver,

Sorry, the previous e-mail slipped by me. I'll try this out later and update.

Thanks,
-Andrew

On Tue, Apr 1, 2008 at 11:06 AM, Oliver Schuster <oliver.s@inbox.com> wrote:
> Hi,
>
>  i've mailed before to lkml and Andrew Paprocki (2008-03-12) directly.
>  But the original patch wasn't changed. Here's a patch to correct the
>  error.
>
>  Description of the error:
>  By introducing the support of 16 Bit timer values for later it8712 an
>  error was made. The value is stored through superio_outw() which cause,
>  that the upper Byte is in the Register called "Watch Dog Timer Time-Out
>  Value (LSB) Register" and the lower in "Watch Dog Timer Time-Out Value
>  (MSB) Register".
>
>  A common value is 60: stored this way the watchdog timer runs out
>  in 4h 16mins. In case of a deadlocked server this is a long time to
>  wait, before the service comes back!
>
>  Regards,
>  Oliver
>
>  Wim Van Sebroeck schrieb:
>  > Hi Oliver,
>  >
>  >> this patch can cause serious problems in the case, that someone use it
>  >> with an it8712 rev. 8 and above.
>  > ...
>  >> Your patch changes it8712f_wdt.c in function t8712f_wdt_update_margin():
>  >>
>  >>> -   superio_outb((margin > 255) ? (margin / 60) : margin, WDT_TIMEOUT);
>  >>> +   if (revision >= 0x08)
>  >>> +           superio_outw(units, WDT_TIMEOUT);
>  >>> +   else
>  >>> +           superio_outb(units, WDT_TIMEOUT);
>  >> but here you can't use superio_outw, because the bytes are swapped
>  >> --historical reason.
>  >>
>  >> I suggest to substitute
>  >>      superio_outw(units, WDT_TIMEOUT);
>  >> with
>  >>      superio_outb(units >> 8, WDT_TIMEOUT + 1);
>  >>      superio_outb(units, WDT_TIMEOUT);
>  >>
>  >
>  > Can you keep "Andrew Paprocki" <andrew@ishiboo.com> in the loop?
>  > Can you also create a patch and test it together with Andrew?
>  > We need to make sure that we fix this before 2.6.25 is there.
>  >
>  > Thanks,
>  > Wim
>
>
>

      reply	other threads:[~2008-04-01 15:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-10 20:14 Wim Van Sebroeck
2008-03-11 18:14 ` Oliver Schuster
2008-03-11 21:02   ` Wim Van Sebroeck
2008-04-01 15:06     ` [PATCH][WATCHDOG] v2.6.25-rc7: it8712f_wdt.c contains an error - was " Oliver Schuster
2008-04-01 15:27       ` Andrew Paprocki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=76366b180804010827r3a8094c6kae46bc3d629eccc9@mail.gmail.com \
    --to=andrew@ishiboo.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oliver.s@inbox.com \
    --cc=olivers137@aol.com \
    --cc=torvalds@linux-foundation.org \
    --cc=wim@iguana.be \
    --subject='Re: [PATCH][WATCHDOG] v2.6.25-rc7: it8712f_wdt.c contains an error - was Re: [WATCHDOG] v2.5.25-rc patches' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).