LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] [WATCHDOG] it8712f_wdt Zero MSB timeout byte when disabling watchdog
@ 2008-04-02 6:43 Andrew Paprocki
0 siblings, 0 replies; only message in thread
From: Andrew Paprocki @ 2008-04-02 6:43 UTC (permalink / raw)
To: linux-kernel; +Cc: Wim Van Sebroeck, Oliver Schuster
[-- Attachment #1: Type: text/plain, Size: 363 bytes --]
I noticed this while testing the latest code. I'm not sure if it is required,
but the normal (or LSB) timeout value is set to zero, so the MSB should
be as well to stay consistent.
If the chip revision is >= 8, set MSB of the 16-bit timeout value to zero
when disabling the watchdog in it8712f_wdt_disable().
Signed-off-by: Andrew Paprocki <andrew@ishiboo.com>
[-- Attachment #2: 2.6.25-rc8-it8712f_wdt-zero-timeout.txt --]
[-- Type: text/plain, Size: 820 bytes --]
Date: Wed, 2 Apr 2008 02:23:33 -0400
Subject: [PATCH] [WATCHDOG] it8712f_wdt Zero MSB timeout byte when disabling watchdog
If the chip revision is >= 8, set MSB of the 16-bit timeout value to zero
when disabling the watchdog in it8712f_wdt_disable().
Signed-off-by: Andrew Paprocki <andrew@ishiboo.com>
---
drivers/watchdog/it8712f_wdt.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/watchdog/it8712f_wdt.c b/drivers/watchdog/it8712f_wdt.c
index ca90c51..445b7e8 100644
--- a/drivers/watchdog/it8712f_wdt.c
+++ b/drivers/watchdog/it8712f_wdt.c
@@ -200,6 +200,8 @@ it8712f_wdt_disable(void)
superio_outb(0, WDT_CONFIG);
superio_outb(0, WDT_CONTROL);
+ if (revision >= 0x08)
+ superio_outb(0, WDT_TIMEOUT + 1);
superio_outb(0, WDT_TIMEOUT);
superio_exit();
--
1.4.4.4
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2008-04-02 6:43 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-04-02 6:43 [PATCH] [WATCHDOG] it8712f_wdt Zero MSB timeout byte when disabling watchdog Andrew Paprocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).