LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: kernel test robot <lkp@intel.com>
Cc: clang-built-linux@googlegroups.com, kbuild-all@lists.01.org,
	linux-kernel@vger.kernel.org, Takashi Iwai <tiwai@suse.de>,
	Kai Vehmanen <kai.vehmanen@linux.intel.com>,
	Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>,
	Bard Liao <bard.liao@intel.com>
Subject: Re: sound/soc/sof/intel/hda-dai.c:265:22: warning: Value stored to 'sdev' during its initialization is never read [clang-analyzer-deadcode.DeadStores]
Date: Tue, 24 Aug 2021 11:40:20 -0500	[thread overview]
Message-ID: <77ba5fc1-2bfa-0e9f-525c-dc260642c7ab@linux.intel.com> (raw)
In-Reply-To: <202108241301.UdSncTEq-lkp@intel.com>

Thanks for the report, I am not sure it's a real issue?
>>> sound/soc/sof/intel/hda-dai.c:265:22: warning: Value stored to 'sdev' during its initialization is never read [clang-analyzer-deadcode.DeadStores]
>            struct snd_sof_dev *sdev =
>                                ^~~~
>    sound/soc/sof/intel/hda-dai.c:265:22: note: Value stored to 'sdev' during its initialization is never read
>            struct snd_sof_dev *sdev =
>                                ^~~~
> fdd961e37e47f2 Keyon Jie         2019-04-12  259  
> fdd961e37e47f2 Keyon Jie         2019-04-12  260  static int hda_link_pcm_prepare(struct snd_pcm_substream *substream,
> fdd961e37e47f2 Keyon Jie         2019-04-12  261  				struct snd_soc_dai *dai)
> fdd961e37e47f2 Keyon Jie         2019-04-12  262  {
> ed3baacd76baa0 Ranjani Sridharan 2019-04-30  263  	struct hdac_ext_stream *link_dev =
> ed3baacd76baa0 Ranjani Sridharan 2019-04-30  264  				snd_soc_dai_get_dma_data(dai, substream);
> fdd961e37e47f2 Keyon Jie         2019-04-12 @265  	struct snd_sof_dev *sdev =
> fdd961e37e47f2 Keyon Jie         2019-04-12  266  				snd_soc_component_get_drvdata(dai->component);
> 1205300af9dba3 Kuninori Morimoto 2020-07-20  267  	struct snd_soc_pcm_runtime *rtd = asoc_substream_to_rtd(substream);
> fdd961e37e47f2 Keyon Jie         2019-04-12  268  	int stream = substream->stream;
> fdd961e37e47f2 Keyon Jie         2019-04-12  269  
> a3ebccb52efdfb Kai Vehmanen      2019-07-22  270  	if (link_dev->link_prepared)
> fdd961e37e47f2 Keyon Jie         2019-04-12  271  		return 0;
> fdd961e37e47f2 Keyon Jie         2019-04-12  272  
> ed3baacd76baa0 Ranjani Sridharan 2019-04-30  273  	dev_dbg(sdev->dev, "hda: prepare stream dir %d\n", substream->stream);
> fdd961e37e47f2 Keyon Jie         2019-04-12  274  
> fdd961e37e47f2 Keyon Jie         2019-04-12  275  	return hda_link_hw_params(substream, &rtd->dpcm[stream].hw_params,
> fdd961e37e47f2 Keyon Jie         2019-04-12  276  				  dai);
> fdd961e37e47f2 Keyon Jie         2019-04-12  277  }
> fdd961e37e47f2 Keyon Jie         2019-04-12  278  

The sdev variable is used in the dev_dbg() log, this looks legit to me?

  reply	other threads:[~2021-08-24 16:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-24  5:05 kernel test robot
2021-08-24 16:40 ` Pierre-Louis Bossart [this message]
2021-08-25 23:04   ` Nick Desaulniers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=77ba5fc1-2bfa-0e9f-525c-dc260642c7ab@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=bard.liao@intel.com \
    --cc=clang-built-linux@googlegroups.com \
    --cc=guennadi.liakhovetski@linux.intel.com \
    --cc=kai.vehmanen@linux.intel.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=tiwai@suse.de \
    --subject='Re: sound/soc/sof/intel/hda-dai.c:265:22: warning: Value stored to '\''sdev'\'' during its initialization is never read [clang-analyzer-deadcode.DeadStores]' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).