From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C951C4338F for ; Tue, 24 Aug 2021 16:53:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 571766135F for ; Tue, 24 Aug 2021 16:53:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233870AbhHXQya (ORCPT ); Tue, 24 Aug 2021 12:54:30 -0400 Received: from mga18.intel.com ([134.134.136.126]:31297 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233911AbhHXQyU (ORCPT ); Tue, 24 Aug 2021 12:54:20 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10086"; a="204486983" X-IronPort-AV: E=Sophos;i="5.84,347,1620716400"; d="scan'208";a="204486983" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Aug 2021 09:53:36 -0700 X-IronPort-AV: E=Sophos;i="5.84,347,1620716400"; d="scan'208";a="685433469" Received: from jlrivera-mobl1.amr.corp.intel.com (HELO [10.212.8.132]) ([10.212.8.132]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Aug 2021 09:53:35 -0700 Subject: Re: sound/soc/sof/intel/hda-dai.c:265:22: warning: Value stored to 'sdev' during its initialization is never read [clang-analyzer-deadcode.DeadStores] To: kernel test robot Cc: clang-built-linux@googlegroups.com, kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, Takashi Iwai , Kai Vehmanen , Guennadi Liakhovetski , Bard Liao References: <202108241301.UdSncTEq-lkp@intel.com> From: Pierre-Louis Bossart Message-ID: <77ba5fc1-2bfa-0e9f-525c-dc260642c7ab@linux.intel.com> Date: Tue, 24 Aug 2021 11:40:20 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <202108241301.UdSncTEq-lkp@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks for the report, I am not sure it's a real issue? >>> sound/soc/sof/intel/hda-dai.c:265:22: warning: Value stored to 'sdev' during its initialization is never read [clang-analyzer-deadcode.DeadStores] > struct snd_sof_dev *sdev = > ^~~~ > sound/soc/sof/intel/hda-dai.c:265:22: note: Value stored to 'sdev' during its initialization is never read > struct snd_sof_dev *sdev = > ^~~~ > fdd961e37e47f2 Keyon Jie 2019-04-12 259 > fdd961e37e47f2 Keyon Jie 2019-04-12 260 static int hda_link_pcm_prepare(struct snd_pcm_substream *substream, > fdd961e37e47f2 Keyon Jie 2019-04-12 261 struct snd_soc_dai *dai) > fdd961e37e47f2 Keyon Jie 2019-04-12 262 { > ed3baacd76baa0 Ranjani Sridharan 2019-04-30 263 struct hdac_ext_stream *link_dev = > ed3baacd76baa0 Ranjani Sridharan 2019-04-30 264 snd_soc_dai_get_dma_data(dai, substream); > fdd961e37e47f2 Keyon Jie 2019-04-12 @265 struct snd_sof_dev *sdev = > fdd961e37e47f2 Keyon Jie 2019-04-12 266 snd_soc_component_get_drvdata(dai->component); > 1205300af9dba3 Kuninori Morimoto 2020-07-20 267 struct snd_soc_pcm_runtime *rtd = asoc_substream_to_rtd(substream); > fdd961e37e47f2 Keyon Jie 2019-04-12 268 int stream = substream->stream; > fdd961e37e47f2 Keyon Jie 2019-04-12 269 > a3ebccb52efdfb Kai Vehmanen 2019-07-22 270 if (link_dev->link_prepared) > fdd961e37e47f2 Keyon Jie 2019-04-12 271 return 0; > fdd961e37e47f2 Keyon Jie 2019-04-12 272 > ed3baacd76baa0 Ranjani Sridharan 2019-04-30 273 dev_dbg(sdev->dev, "hda: prepare stream dir %d\n", substream->stream); > fdd961e37e47f2 Keyon Jie 2019-04-12 274 > fdd961e37e47f2 Keyon Jie 2019-04-12 275 return hda_link_hw_params(substream, &rtd->dpcm[stream].hw_params, > fdd961e37e47f2 Keyon Jie 2019-04-12 276 dai); > fdd961e37e47f2 Keyon Jie 2019-04-12 277 } > fdd961e37e47f2 Keyon Jie 2019-04-12 278 The sdev variable is used in the dev_dbg() log, this looks legit to me?