From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F8B5C2BB1D for ; Fri, 13 Mar 2020 17:29:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 20EF8206BE for ; Fri, 13 Mar 2020 17:29:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727083AbgCMR3R (ORCPT ); Fri, 13 Mar 2020 13:29:17 -0400 Received: from mga04.intel.com ([192.55.52.120]:49216 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726446AbgCMR3Q (ORCPT ); Fri, 13 Mar 2020 13:29:16 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Mar 2020 10:29:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,549,1574150400"; d="scan'208";a="237017325" Received: from sblancoa-mobl.amr.corp.intel.com (HELO [10.251.232.239]) ([10.251.232.239]) by fmsmga008.fm.intel.com with ESMTP; 13 Mar 2020 10:29:13 -0700 Subject: Re: [PATCH 04/16] soundwire: cadence: handle error cases with CONFIG_UPDATE To: Vinod Koul Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, tiwai@suse.de, broonie@kernel.org, gregkh@linuxfoundation.org, jank@cadence.com, srinivas.kandagatla@linaro.org, slawomir.blauciak@intel.com, Bard liao , Rander Wang , Ranjani Sridharan , Hui Wang , Sanyog Kale References: <20200311184128.4212-1-pierre-louis.bossart@linux.intel.com> <20200311184128.4212-5-pierre-louis.bossart@linux.intel.com> <20200313120855.GF4885@vkoul-mobl> From: Pierre-Louis Bossart Message-ID: <77c5b945-4738-f3fe-5e8f-9cffaf9a74c7@linux.intel.com> Date: Fri, 13 Mar 2020 12:09:11 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200313120855.GF4885@vkoul-mobl> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/13/20 7:08 AM, Vinod Koul wrote: > On 11-03-20, 13:41, Pierre-Louis Bossart wrote: >> config_update() may time out or cannot be use in ClockStopMode >> >> Signed-off-by: Pierre-Louis Bossart >> --- >> drivers/soundwire/cadence_master.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/drivers/soundwire/cadence_master.c b/drivers/soundwire/cadence_master.c >> index 71cba2585151..4089c271305a 100644 >> --- a/drivers/soundwire/cadence_master.c >> +++ b/drivers/soundwire/cadence_master.c >> @@ -239,6 +239,11 @@ static int cdns_config_update(struct sdw_cdns *cdns) >> { >> int ret; >> >> + if (sdw_cdns_is_clock_stop(cdns)) { >> + dev_err(cdns->dev, "Cannot program MCP_CONFIG_UPDATE in ClockStopMode\n"); > > This looks fine but duplicates the log, so maybe you can remove from > here or preceding patch... Or use single line as I suggested in that > patch and keep this as is. It doesn't duplicate it. In Patch1 it's a dev_dbg log that's useful for integration, and that function is used in other places (see the soundwire:intel series). In this patch this is a clear error leading to a master hang.