From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932127AbeEHTg1 (ORCPT ); Tue, 8 May 2018 15:36:27 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:54960 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751533AbeEHTg0 (ORCPT ); Tue, 8 May 2018 15:36:26 -0400 X-Google-Smtp-Source: AB8JxZro2UeozRXbV0JbrCFPY1GguTA+YM8KDWK02QiuCxfUjYvdjPOAqkO7/Vi6cm38JrOVyEesow== From: Srinivas Kandagatla Subject: Re: [PATCH RFC] drivers: nvmem: Export nvmem_add_cells() To: Andrew Lunn Cc: linux-kernel@vger.kernel.org, andrew.smirnov@gmail.com References: <1525547507-1428-1-git-send-email-andrew@lunn.ch> <20180508131654.GD2888@lunn.ch> Message-ID: <785a7f2c-7cf0-6462-e903-df9f7685616c@linaro.org> Date: Tue, 8 May 2018 20:36:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20180508131654.GD2888@lunn.ch> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/05/18 14:16, Andrew Lunn wrote: > On Tue, May 08, 2018 at 09:35:55AM +0100, Srinivas Kandagatla wrote: >> >> >> On 05/05/18 20:11, Andrew Lunn wrote: >>> Not all platforms use device tree. It is useful to be able to add >>> cells to a NVMEM device from code. Export nvmem_add_cells() so making >>> this possible. >>> >>> This required changing the parameters a bit, so that just the cells >>> and the number of cells are passed, not the whole nvmem config >>> structure. >>> >>> Signed-off-by: Andrew Lunn >> >>> --- >>> >>> This is an RFC. >>> >>> I have an intel platform with an AT24 EEPROM. I want to make use of >>> nvmem, but don't have device tree to be able to specify cells. I have >>> an x86 platform driver which does: >>> >>> struct nvmem_cell_info nameplate_cells[] = { >>> { >>> .name = "checksum", >>> .offset = 2, >>> .bytes = 1, >>> }, >>> { >>> .name = "part_number", >>> .offset = 11, >>> .bytes = 11, >>> }, >>> }; >>> >>> err = nvmem_add_cells(nvmem, nameplate_cells, >>> ARRAY_SIZE(nameplate_cells)); >>> if (err) { >>> dev_err(dev, "Error adding cells to nameplate nvmem device\n"); >>> return; >>> } >>> >>> cell = nvmem_cell_get(NULL, "checksum"); >>> >>> >>> drivers/nvmem/core.c | 15 ++++++++------- >>> include/linux/nvmem-provider.h | 11 +++++++++++ >>> 2 files changed, 19 insertions(+), 7 deletions(-) >>> >> >> >> Thanks Andrew for the patch, >> >> Overall the patch looks good to me, >> I would like to see some kernel doc for this new exported function > > Hi Srini > > O.K. I can do that. > > Will you accept the patch without a user of this API? The driver which That should be okay!, there are other users who can potentially benefit from this. Thanks, srini