LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] dwmac4_prog_mtl_tx_algorithms() missing write operation
@ 2019-05-08  1:36 Cheng Han
  2019-05-08  9:20 ` Jose Abreu
  0 siblings, 1 reply; 4+ messages in thread
From: Cheng Han @ 2019-05-08  1:36 UTC (permalink / raw)
  To: peppe.cavallaro, alexandre.torgue, joabreu, davem
  Cc: netdev, linux-kernel, Cheng Han

Signed-off-by: Cheng Han <hancheng2009@gmail.com>
---
 drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c b/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c
index 7e5d5db..b4bb562 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c
@@ -192,6 +192,8 @@ static void dwmac4_prog_mtl_tx_algorithms(struct mac_device_info *hw,
 	default:
 		break;
 	}
+
+	writel(value, ioaddr + MTL_OPERATION_MODE);
 }
 
 static void dwmac4_set_mtl_tx_queue_weight(struct mac_device_info *hw,
-- 
1.9.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [PATCH] dwmac4_prog_mtl_tx_algorithms() missing write operation
  2019-05-08  1:36 [PATCH] dwmac4_prog_mtl_tx_algorithms() missing write operation Cheng Han
@ 2019-05-08  9:20 ` Jose Abreu
  0 siblings, 0 replies; 4+ messages in thread
From: Jose Abreu @ 2019-05-08  9:20 UTC (permalink / raw)
  To: Cheng Han, peppe.cavallaro, alexandre.torgue, davem; +Cc: netdev, linux-kernel

From: Cheng Han <hancheng2009@gmail.com>
Date: Wed, May 08, 2019 at 02:36:57

> Signed-off-by: Cheng Han <hancheng2009@gmail.com>

Please specify that this is for -net tree, write a commit log and add the 
"Fixes" tag.

Thanks,
Jose Miguel Abreu

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dwmac4_prog_mtl_tx_algorithms() missing write operation
  2019-05-09  3:13 Cheng Han
@ 2019-05-09 16:20 ` David Miller
  0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2019-05-09 16:20 UTC (permalink / raw)
  To: hancheng2009
  Cc: peppe.cavallaro, alexandre.torgue, joabreu, netdev, linux-kernel

From: Cheng Han <hancheng2009@gmail.com>
Date: Thu,  9 May 2019 11:13:41 +0800

> net: ethernet: stmmac: dwmac4_prog_mtl_tx_algorithms() missing write operation
> 
> The value of MTL_OPERATION_MODE is not written back
> 
> Signed-off-by: Cheng Han <hancheng2009@gmail.com>

Good catch, applied, thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] dwmac4_prog_mtl_tx_algorithms() missing write operation
@ 2019-05-09  3:13 Cheng Han
  2019-05-09 16:20 ` David Miller
  0 siblings, 1 reply; 4+ messages in thread
From: Cheng Han @ 2019-05-09  3:13 UTC (permalink / raw)
  To: peppe.cavallaro, alexandre.torgue, joabreu, davem
  Cc: netdev, linux-kernel, Cheng Han

net: ethernet: stmmac: dwmac4_prog_mtl_tx_algorithms() missing write operation

The value of MTL_OPERATION_MODE is not written back

Signed-off-by: Cheng Han <hancheng2009@gmail.com>
---
 drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c b/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c
index 7e5d5db..b4bb562 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c
@@ -192,6 +192,8 @@ static void dwmac4_prog_mtl_tx_algorithms(struct mac_device_info *hw,
 	default:
 		break;
 	}
+
+	writel(value, ioaddr + MTL_OPERATION_MODE);
 }
 
 static void dwmac4_set_mtl_tx_queue_weight(struct mac_device_info *hw,
-- 
1.9.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-05-09 16:20 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-08  1:36 [PATCH] dwmac4_prog_mtl_tx_algorithms() missing write operation Cheng Han
2019-05-08  9:20 ` Jose Abreu
2019-05-09  3:13 Cheng Han
2019-05-09 16:20 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).