LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Samuel Holland <samuel@sholland.org>
To: Maxime Ripard <maxime@cerno.tech>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Rob Herring <robh+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-sunxi@lists.linux.dev, linux-watchdog@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: watchdog: sunxi: Add compatible for R329
Date: Thu, 19 Aug 2021 23:04:52 -0500	[thread overview]
Message-ID: <791b7548-cd7b-6cdf-8364-671f6a2029a9@sholland.org> (raw)
In-Reply-To: <20210818090732.wdickyw67oc4zqpt@gilmour>

On 8/18/21 4:07 AM, Maxime Ripard wrote:
> Hi,
> 
> On Wed, Aug 04, 2021 at 11:57:14PM -0500, Samuel Holland wrote:
>> On existing SoCs, the watchdog has a single clock input: HOSC (OSC24M)
>> divided by 750.  However, starting with R329, LOSC (OSC32k) is added as
>> an alternative clock source, with a bit to switch between them.
>>
>> Since 24 MHz / 750 == 32 kHz, not 32.768 kHz, the hardware adjusts the
>> cycle counts to keep the timeouts independent of the clock source. This
>> keeps the programming interface backward-compatible.
>>
>> R329 also adds two new registers, to allow software to immediately drive
>> the SoC reset signal.
>>
>> Signed-off-by: Samuel Holland <samuel@sholland.org>
>> ---
>> Changes v1 to v2:
>>  - Switch from enum to const
>>  - Add descriptions to "clocks" items
>>
>>  .../watchdog/allwinner,sun4i-a10-wdt.yaml     | 32 ++++++++++++++++++-
>>  1 file changed, 31 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml b/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml
>> index 9aa3c313c49f..8fa5b0d32381 100644
>> --- a/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml
>> +++ b/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml
>> @@ -24,6 +24,7 @@ properties:
>>                - allwinner,sun50i-a100-wdt
>>                - allwinner,sun50i-h6-wdt
>>                - allwinner,sun50i-h616-wdt
>> +              - allwinner,sun50i-r329-wdt
>>            - const: allwinner,sun6i-a31-wdt
>>        - items:
>>            - const: allwinner,suniv-f1c100s-wdt
>> @@ -33,7 +34,18 @@ properties:
>>      maxItems: 1
>>  
>>    clocks:
>> -    maxItems: 1
>> +    minItems: 1
>> +    maxItems: 2
>> +    items:
>> +      - description: High-frequency oscillator input, divided internally
>> +      - description: Low-frequency oscillator input, only found on some variants
>> +
>> +  clock-names:
>> +    minItems: 1
>> +    maxItems: 2
>> +    items:
>> +      - const: hosc
>> +      - const: losc
>>  
>>    interrupts:
>>      maxItems: 1
>> @@ -44,6 +56,24 @@ required:
>>    - clocks
>>    - interrupts
>>  
>> +if:
>> +  properties:
>> +    compatible:
>> +      contains:
>> +        enum:
>> +          - allwinner,sun50i-r329-wdt
>> +
>> +then:
>> +  properties:
>> +    clocks:
>> +      minItems: 2
>> +
>> +    clock-names:
>> +      minItems: 2
>> +
>> +  required:
>> +    - clock-names
>> +
> 
> We should also make sure through an else clause that all the other SoCs
> have a length of one for both clocks and clock-names

Yes, I'll do that for v3.

> Also, it looks like you forgot the patch to enable the compatible in the
> driver?

R329 has a fallback to A31, so it doesn't need any changes to the driver.

Regards,
Samuel

      reply	other threads:[~2021-08-20  4:05 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-05  4:57 Samuel Holland
2021-08-05  4:57 ` [PATCH v2 2/3] dt-bindings: watchdog: sunxi: Add compatible for D1 Samuel Holland
2021-08-18  9:07   ` Maxime Ripard
2021-08-28 16:23   ` Guenter Roeck
2021-08-05  4:57 ` [PATCH v2 3/3] watchdog: sunxi_wdt: Add support " Samuel Holland
2021-08-18  9:08   ` Maxime Ripard
2021-08-13 17:46 ` [PATCH v2 1/3] dt-bindings: watchdog: sunxi: Add compatible for R329 Rob Herring
2021-08-18  9:07 ` Maxime Ripard
2021-08-20  4:04   ` Samuel Holland [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=791b7548-cd7b-6cdf-8364-671f6a2029a9@sholland.org \
    --to=samuel@sholland.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=maxime@cerno.tech \
    --cc=robh+dt@kernel.org \
    --cc=wens@csie.org \
    --cc=wim@linux-watchdog.org \
    --subject='Re: [PATCH v2 1/3] dt-bindings: watchdog: sunxi: Add compatible for R329' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).