LKML Archive on
help / color / mirror / Atom feed
From: Marcel Holtmann <>
To: Vasily Khoruzhick <>
Cc: Johan Hedberg <>,
	"David S. Miller" <>,,,,
Subject: Re: [PATCH] Revert "Bluetooth: Align minimum encryption key size for LE and BR/EDR connections"
Date: Wed, 22 May 2019 09:08:02 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Hi Vasily,

>> This reverts commit d5bb334a8e171b262e48f378bd2096c0ea458265.
>> This commit breaks some HID devices, see [1] for details
>> Signed-off-by: Vasily Khoruzhick <>
>> Cc:
> let me have a look at this. Maybe there is a missing initialization for older HID devices that we need to handle. Do you happen to have the full btmon binary trace from controller initialization to connection attempt for me?
> Are both devices Bluetooth 2.1 or later device that are supporting Secure Simple Pairing? Or is one of them a Bluetooth 2.0 or earlier device?

I am almost certain that you have a Bluetooth 2.0 mouse. I made a really stupid mistake in the key size check logic and forgot to bind it to SSP support. Can you please check the patch that I just send you.



  reply	other threads:[~2019-05-22  7:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-22  5:20 Vasily Khoruzhick
2019-05-22  6:38 ` Marcel Holtmann
2019-05-22  7:08   ` Marcel Holtmann [this message]
2019-05-23 14:52     ` Vasily Khoruzhick
2019-06-11 19:56       ` Vasily Khoruzhick
2019-06-11 21:36         ` Marcel Holtmann
2019-06-12  7:07           ` Greg Kroah-Hartman
2019-06-12  9:38             ` Bastien Nocera
2019-06-12 10:04               ` Johan Hedberg
2019-06-13  7:35         ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] Revert "Bluetooth: Align minimum encryption key size for LE and BR/EDR connections"' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).