LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Georgi Djakov <djakov@kernel.org>
To: Alex Elder <elder@linaro.org>,
	bjorn.andersson@linaro.org, agross@kernel.org
Cc: robh+dt@kernel.org, elder@kernel.org,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] arm64: dts: qcom: sm8350: fix IPA interconnects
Date: Tue, 10 Aug 2021 19:27:39 +0300	[thread overview]
Message-ID: <7a199975-d41a-0716-57d1-7a03af2eb6a4@kernel.org> (raw)
In-Reply-To: <20210804210214.1891755-5-elder@linaro.org>

On 5.08.21 0:02, Alex Elder wrote:
> There should only be two interconnects defined for IPA on the
> QUalcomm SM8350 SoC.  The names should also match those specified by
> the IPA Device Tree binding.
> 
> Signed-off-by: Alex Elder <elder@linaro.org>

Acked-by: Georgi Djakov <djakov@kernel.org>

> ---
>   arch/arm64/boot/dts/qcom/sm8350.dtsi | 8 +++-----
>   1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi
> index a631d58166b1c..01f60a3bd1c14 100644
> --- a/arch/arm64/boot/dts/qcom/sm8350.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi
> @@ -666,12 +666,10 @@ ipa: ipa@1e40000 {
>   			clocks = <&rpmhcc RPMH_IPA_CLK>;
>   			clock-names = "core";
>   
> -			interconnects = <&aggre2_noc MASTER_IPA &gem_noc SLAVE_LLCC>,
> -					<&mc_virt MASTER_LLCC &mc_virt SLAVE_EBI1>,
> +			interconnects = <&aggre2_noc MASTER_IPA &mc_virt SLAVE_EBI1>,
>   					<&gem_noc MASTER_APPSS_PROC &config_noc SLAVE_IPA_CFG>;
> -			interconnect-names = "ipa_to_llcc",
> -					     "llcc_to_ebi1",
> -					     "appss_to_ipa";
> +			interconnect-names = "memory",
> +					     "config";
>   
>   			qcom,smem-states = <&ipa_smp2p_out 0>,
>   					   <&ipa_smp2p_out 1>;
> 


      reply	other threads:[~2021-08-10 16:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-04 21:02 [PATCH 0/4] arm64: dts: qcom: IPA-related DTS updates Alex Elder
2021-08-04 21:02 ` [PATCH 1/4] arm64: dts: qcom: sc7280: add IPA information Alex Elder
2021-08-05 23:51   ` Matthias Kaehlcke
2021-08-04 21:02 ` [PATCH 2/4] arm64: dts: qcom: sc7280: enable IPA for sc7280-idp Alex Elder
2021-08-05 23:53   ` Matthias Kaehlcke
2021-08-04 21:02 ` [PATCH 3/4] arm64: dts: qcom: sc7180: define ipa_fw_mem node Alex Elder
2021-08-05 23:55   ` Matthias Kaehlcke
2021-08-04 21:02 ` [PATCH 4/4] arm64: dts: qcom: sm8350: fix IPA interconnects Alex Elder
2021-08-10 16:27   ` Georgi Djakov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7a199975-d41a-0716-57d1-7a03af2eb6a4@kernel.org \
    --to=djakov@kernel.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=elder@kernel.org \
    --cc=elder@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --subject='Re: [PATCH 4/4] arm64: dts: qcom: sm8350: fix IPA interconnects' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).