LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Jonas Bonn" <jonas.bonn@gmail.com>
To: "Jon Smirl" <jonsmirl@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC] API for system clocks (oscillators)
Date: Thu, 30 Oct 2008 18:01:42 +0100	[thread overview]
Message-ID: <7a6abd110810301001r7fc311adifd85fece79cb5c45@mail.gmail.com> (raw)
In-Reply-To: <9e4733910810300939x40a7afear7a49557604ced628@mail.gmail.com>

>
> You could probably work those features into the existing clk framework.
> clk_set_rate() could compute the constrains and return an error.
> The API could be expanded with notifier support.
>

I started in this end, too, and got frequency change notification
working, at least.  There are issues with mutexes that "might_sleep"
when calling set_rate from cpuidle driver, but nothing that can't be
fixed...

What drove me to document a new interface is the fact that there are
so many users of "struct clk" already, that it becomes conceptually
easier to dream up something new that stays out of the way, even if
that new  thing becomes just a wrapper around the existing interface
(which I am well aware that it largely is) with some new
functionality.  If we can bolt the new stuff onto the existing stuff,
then that's even better; however, I know that yesterday I was longing
to be able to start from scratch and "do it right"!  After writing my
document, though, I think I have largely validated the model that's in
place...

That said, I still think there is value in the additional features.

/Jonas

  parent reply	other threads:[~2008-10-30 17:01 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-30 14:41 Jonas Bonn
2008-10-30 15:31 ` Alan Jenkins
2008-10-30 16:19   ` Jonas Bonn
2008-10-30 15:40 ` Jon Smirl
2008-10-30 16:27   ` Jonas Bonn
2008-10-30 16:39     ` Jon Smirl
2008-10-30 16:40       ` Jon Smirl
2008-10-30 17:01       ` Jonas Bonn [this message]
2008-10-30 20:13         ` Mark Brown
2008-10-30 20:15           ` Jonas Bonn
2008-10-31 11:20             ` Mark Brown
2008-11-01 10:55               ` Jonas Bonn
2008-10-30 20:08 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7a6abd110810301001r7fc311adifd85fece79cb5c45@mail.gmail.com \
    --to=jonas.bonn@gmail.com \
    --cc=jonsmirl@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [RFC] API for system clocks (oscillators)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).