LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [2.6 patch] let BLK_DEV_AMD74XX depend on X86
@ 2007-01-11 13:49 Adrian Bunk
  2007-01-11 16:48 ` Alan
  2007-01-11 17:42 ` Segher Boessenkool
  0 siblings, 2 replies; 4+ messages in thread
From: Adrian Bunk @ 2007-01-11 13:49 UTC (permalink / raw)
  To: B.Zolnierkiewicz; +Cc: linux-ide, linux-kernel

It's unlikely that this driver will ever be of any use on other 
architectures.

This fixes the following compile error on ia64:

<--  snip  -->

...
  CC      drivers/ide/pci/amd74xx.o
/home/bunk/linux/kernel-2.6/linux-2.6.20-rc3-mm1/drivers/ide/pci/amd74xx.c: In function 'init_hwif_amd74xx':
/home/bunk/linux/kernel-2.6/linux-2.6.20-rc3-mm1/drivers/ide/pci/amd74xx.c:421: warning: implicit declaration of function 'pci_get_legacy_ide_irq'
  CC      drivers/ide/pci/cmd64x.o
...
  LD      .tmp_vmlinux1
drivers/built-in.o: In function `init_hwif_amd74xx':
/home/bunk/linux/kernel-2.6/linux-2.6.20-rc3-mm1/drivers/ide/pci/amd74xx.c:421: undefined reference to `pci_get_legacy_ide_irq'
make[1]: *** [.tmp_vmlinux1] Error 1

<--  snip  -->


This fixes kernel Bugzilla #6644.


Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.6.20-rc3-mm1/drivers/ide/Kconfig.old	2007-01-11 11:15:24.000000000 +0100
+++ linux-2.6.20-rc3-mm1/drivers/ide/Kconfig	2007-01-11 11:15:37.000000000 +0100
@@ -478,6 +478,7 @@
 
 config BLK_DEV_AMD74XX
 	tristate "AMD and nVidia IDE support"
+	depends on X86
 	help
 	  This driver adds explicit support for AMD-7xx and AMD-8111 chips
 	  and also for the nVidia nForce chip.  This allows the kernel to


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [2.6 patch] let BLK_DEV_AMD74XX depend on X86
  2007-01-11 13:49 [2.6 patch] let BLK_DEV_AMD74XX depend on X86 Adrian Bunk
@ 2007-01-11 16:48 ` Alan
  2007-01-11 16:51   ` Bartlomiej Zolnierkiewicz
  2007-01-11 17:42 ` Segher Boessenkool
  1 sibling, 1 reply; 4+ messages in thread
From: Alan @ 2007-01-11 16:48 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: B.Zolnierkiewicz, linux-ide, linux-kernel

On Thu, 11 Jan 2007 14:49:17 +0100
Adrian Bunk <bunk@stusta.de> wrote:

> It's unlikely that this driver will ever be of any use on other 
> architectures.
> 
> This fixes the following compile error on ia64:

NAK

pci_get_legacy_ide_irq() is a required method for all platforms and is
usually filled in by asm-generic/pci.h

Please fix the IA64 tree to do the right thing.

Alan

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [2.6 patch] let BLK_DEV_AMD74XX depend on X86
  2007-01-11 16:48 ` Alan
@ 2007-01-11 16:51   ` Bartlomiej Zolnierkiewicz
  0 siblings, 0 replies; 4+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2007-01-11 16:51 UTC (permalink / raw)
  To: Alan; +Cc: Adrian Bunk, linux-ide, linux-kernel

On 1/11/07, Alan <alan@lxorguk.ukuu.org.uk> wrote:
> On Thu, 11 Jan 2007 14:49:17 +0100
> Adrian Bunk <bunk@stusta.de> wrote:
>
> > It's unlikely that this driver will ever be of any use on other
> > architectures.
> >
> > This fixes the following compile error on ia64:
>
> NAK
>
> pci_get_legacy_ide_irq() is a required method for all platforms and is
> usually filled in by asm-generic/pci.h
>
> Please fix the IA64 tree to do the right thing.

I've already sent a patch do do this...

http://lkml.org/lkml/2007/1/11/118

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [2.6 patch] let BLK_DEV_AMD74XX depend on X86
  2007-01-11 13:49 [2.6 patch] let BLK_DEV_AMD74XX depend on X86 Adrian Bunk
  2007-01-11 16:48 ` Alan
@ 2007-01-11 17:42 ` Segher Boessenkool
  1 sibling, 0 replies; 4+ messages in thread
From: Segher Boessenkool @ 2007-01-11 17:42 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: B.Zolnierkiewicz, linux-kernel, linux-ide

> It's unlikely that this driver will ever be of any use on other
> architectures.

It's already being used, for example, the AMD8111 is used
one some PowerPC systems (some with IDE connected even).


Segher


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2007-01-11 17:46 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-01-11 13:49 [2.6 patch] let BLK_DEV_AMD74XX depend on X86 Adrian Bunk
2007-01-11 16:48 ` Alan
2007-01-11 16:51   ` Bartlomiej Zolnierkiewicz
2007-01-11 17:42 ` Segher Boessenkool

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).