From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C0B6C31E47 for ; Sat, 15 Jun 2019 07:47:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 04AC32184C for ; Sat, 15 Jun 2019 07:46:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="TtlfghLv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726501AbfFOHq6 (ORCPT ); Sat, 15 Jun 2019 03:46:58 -0400 Received: from mail-wm1-f47.google.com ([209.85.128.47]:35011 "EHLO mail-wm1-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726236AbfFOHq6 (ORCPT ); Sat, 15 Jun 2019 03:46:58 -0400 Received: by mail-wm1-f47.google.com with SMTP id c6so4347468wml.0 for ; Sat, 15 Jun 2019 00:46:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Sa6UnnA/U84OFA6hrhWdVHqFPfLzbLKoXVimXehYFE4=; b=TtlfghLvaw3bkTQc8btWmwE+eW5HioLBPwuumJkr4MUQnBiwwLZq6HHulRBD6d2KSj +OyvCVDc6DnG0rMxkZAkRHnQSx8mVj6w4613RHXDwAKwVjWzUlTxl0qSrjPDoKsa4rRw VQq4mtebO7peHi8uHnhbggwDrHTrVX/0I1YDDvuiMl2r9foow3/flcxtvylfpamNAtS7 AeGTjN18lB4/+xktjcUMqWJWT6h44gZmDyOWXY/LrvGkr2KlyS3psPQsQxmHrqanrug7 S2L5iyA8P6AQYcAjqyiQqONbsJ66iazw1eA6lrA1mIDyHmQeKHPhDJNUpBR41/H3pCql cV8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Sa6UnnA/U84OFA6hrhWdVHqFPfLzbLKoXVimXehYFE4=; b=hSpUQB1EAoAc+LGxmrtaNHvDGjWfGBV76KmWcnBcfoNZbkL4dt7Ox6UYUwiZcH2p+W bsRko877/1iZi3yY5TKjfeLJaguHuqwD/4xh9YNe4PPiT5GgXqqahKmxexKp99J43JKJ Bm9/3aqjnYxP62IHZD8FTqx8I60zKKAidEzp8jbct88EbDDWyX6HVAE2WcHFkWnVZDQI WzwEs0RWssHs+nLehJ3keHXOwWAivhPwTDn2/o5TJknbS+J3Y04pQPEk3Ltn4dhonB3M rqbF2mtuQwbR2IXQjcRQF5r2pEKFU6hYZ/IwQpP2UQ5JmArANawEYYftLEaF70zO7D9+ hKyQ== X-Gm-Message-State: APjAAAXHs7UgKKyQVeNAgKKqt6k1wZeXOgGVAABM0FzqiUOuxkhrOA/G eYL2mpqxi/BYsbacYwGsPXDHAzmItCeo/biR X-Google-Smtp-Source: APXvYqzuwBXBhQ+5KslugzKdfR+CxtJ7cA7mO5un/KisvV8H5UV3/KDzQ1j649g+v2RrgMi9hczMNA== X-Received: by 2002:a1c:1947:: with SMTP id 68mr10754093wmz.171.1560584815596; Sat, 15 Jun 2019 00:46:55 -0700 (PDT) Received: from [192.168.88.149] ([62.170.2.124]) by smtp.gmail.com with ESMTPSA id f21sm4477839wmb.2.2019.06.15.00.46.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 15 Jun 2019 00:46:54 -0700 (PDT) Subject: Re: [PATCH] block: genhd: Use struct_size() helper To: "Gustavo A. R. Silva" Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: <20190531184754.GA26040@embeddedor> From: Jens Axboe Message-ID: <7cc1ada7-52eb-eb18-c56b-0b1e47cf1530@kernel.dk> Date: Sat, 15 Jun 2019 01:46:52 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190531184754.GA26040@embeddedor> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/31/19 12:47 PM, Gustavo A. R. Silva wrote: > Make use of the struct_size() helper instead of an open-coded version > in order to avoid any potential type mistakes, in particular in the > context in which this code is being used. > > So, replace the following form: > > sizeof(*new_ptbl) + target * sizeof(new_ptbl->part[0]) > > with: > > struct_size(new_ptbl, part, target) > > Also, notice that variable size is unnecessary, hence it is removed. > > This code was detected with the help of Coccinelle. Applied, thanks. -- Jens Axboe