LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] drivers/video/s1d13xxxfb.c as module with dbg
@ 2007-11-10 15:51 Stanislav Brabec
  2007-11-10 23:29 ` dave chung
  0 siblings, 1 reply; 4+ messages in thread
From: Stanislav Brabec @ 2007-11-10 15:51 UTC (permalink / raw)
  To: linux-kernel; +Cc: Thibaut VARENE

Attached patch fixes two compilation problems of s1d13xxxfb.c:
- Fixes outdated dbg() message to fix compilation error with debugging enabled.
- Do not read kernel command line options when compiled as module.

Signed-off-by: Stanislav Brabec <utx@penguin.cz>

--- linux-2.6.23/drivers/video/s1d13xxxfb.c	2007-10-09 22:31:38.000000000 +0200
+++ linux-2.6.23/drivers/video/s1d13xxxfb.c	2007-11-02 16:48:34.000000000 +0100
@@ -540,7 +540,7 @@
 	int ret = 0;
 	u8 revision;
 
-	dbg("probe called: device is %p\n", dev);
+	dbg("probe called: device is %p\n", pdev);
 
 	printk(KERN_INFO "Epson S1D13XXX FB Driver\n");
 
@@ -753,8 +753,11 @@
 static int __init
 s1d13xxxfb_init(void)
 {
+
+#ifndef MODULE
 	if (fb_get_options("s1d13xxxfb", NULL))
 		return -ENODEV;
+#endif
 
 	return platform_driver_register(&s1d13xxxfb_driver);
 }


________________________________________________________________________
Stanislav Brabec
http://www.penguin.cz/~utx


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2007-11-13 23:16 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-11-10 15:51 [PATCH] drivers/video/s1d13xxxfb.c as module with dbg Stanislav Brabec
2007-11-10 23:29 ` dave chung
2007-11-11 15:17   ` Thibaut VARENE
2007-11-13 23:21   ` Kristoffer Ericson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).