LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] ASoC: mediatek: SND_SOC_MT8195 should depend on ARCH_MEDIATEK
@ 2021-08-31 13:18 Geert Uytterhoeven
  2021-09-01  3:48 ` Trevor Wu
  2021-09-01 18:14 ` Mark Brown
  0 siblings, 2 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2021-08-31 13:18 UTC (permalink / raw)
  To: Liam Girdwood, Mark Brown, Trevor Wu
  Cc: Matthias Brugger, Jaroslav Kysela, Takashi Iwai, alsa-devel,
	linux-arm-kernel, linux-mediatek, linux-kernel,
	Geert Uytterhoeven

The Mediatek MT8195 sound hardware is only present on Mediatek MT8195
SoCs.  Hence add a dependency on ARCH_MEDIATEK, to prevent asking the
user about this driver when configuring a kernel without Mediatek SoC
support.

Fixes: 6746cc858259985a ("ASoC: mediatek: mt8195: add platform driver")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 sound/soc/mediatek/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/mediatek/Kconfig b/sound/soc/mediatek/Kconfig
index cf567a89f421b4c0..c8c815f599da90bf 100644
--- a/sound/soc/mediatek/Kconfig
+++ b/sound/soc/mediatek/Kconfig
@@ -187,6 +187,7 @@ config SND_SOC_MT8192_MT6359_RT1015_RT5682
 
 config SND_SOC_MT8195
 	tristate "ASoC support for Mediatek MT8195 chip"
+	depends on ARCH_MEDIATEK || COMPILE_TEST
 	select SND_SOC_MEDIATEK
 	help
 	  This adds ASoC platform driver support for Mediatek MT8195 chip
-- 
2.25.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ASoC: mediatek: SND_SOC_MT8195 should depend on ARCH_MEDIATEK
  2021-08-31 13:18 [PATCH] ASoC: mediatek: SND_SOC_MT8195 should depend on ARCH_MEDIATEK Geert Uytterhoeven
@ 2021-09-01  3:48 ` Trevor Wu
  2021-09-01  7:14   ` Geert Uytterhoeven
  2021-09-01 18:14 ` Mark Brown
  1 sibling, 1 reply; 4+ messages in thread
From: Trevor Wu @ 2021-09-01  3:48 UTC (permalink / raw)
  To: Geert Uytterhoeven, Liam Girdwood, Mark Brown
  Cc: Matthias Brugger, Jaroslav Kysela, Takashi Iwai, alsa-devel,
	linux-arm-kernel, linux-mediatek, linux-kernel

On Tue, 2021-08-31 at 15:18 +0200, Geert Uytterhoeven wrote:
> The Mediatek MT8195 sound hardware is only present on Mediatek MT8195
> SoCs.  Hence add a dependency on ARCH_MEDIATEK, to prevent asking the
> user about this driver when configuring a kernel without Mediatek SoC
> support.
> 
> Fixes: 6746cc858259985a ("ASoC: mediatek: mt8195: add platform
> driver")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  sound/soc/mediatek/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/soc/mediatek/Kconfig b/sound/soc/mediatek/Kconfig
> index cf567a89f421b4c0..c8c815f599da90bf 100644
> --- a/sound/soc/mediatek/Kconfig
> +++ b/sound/soc/mediatek/Kconfig
> @@ -187,6 +187,7 @@ config SND_SOC_MT8192_MT6359_RT1015_RT5682
>  
>  config SND_SOC_MT8195
>  	tristate "ASoC support for Mediatek MT8195 chip"
> +	depends on ARCH_MEDIATEK || COMPILE_TEST
>  	select SND_SOC_MEDIATEK
>  	help
>  	  This adds ASoC platform driver support for Mediatek MT8195
> chip

Hi Geert,

Thanks for your patch first.
I really missed the dependency declaration.
But we only test "depends on ARCH_MEDIATEK" internally, maybe removing
"COMPILE_TEST" like other MTK series is better for the maintenance in
the future.

Thanks,
Trevor

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ASoC: mediatek: SND_SOC_MT8195 should depend on ARCH_MEDIATEK
  2021-09-01  3:48 ` Trevor Wu
@ 2021-09-01  7:14   ` Geert Uytterhoeven
  0 siblings, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2021-09-01  7:14 UTC (permalink / raw)
  To: Trevor Wu
  Cc: Liam Girdwood, Mark Brown, Matthias Brugger, Jaroslav Kysela,
	Takashi Iwai, ALSA Development Mailing List, Linux ARM,
	linux-mediatek, Linux Kernel Mailing List

Hi Trevor,

On Wed, Sep 1, 2021 at 5:48 AM Trevor Wu <trevor.wu@mediatek.com> wrote:
> On Tue, 2021-08-31 at 15:18 +0200, Geert Uytterhoeven wrote:
> > The Mediatek MT8195 sound hardware is only present on Mediatek MT8195
> > SoCs.  Hence add a dependency on ARCH_MEDIATEK, to prevent asking the
> > user about this driver when configuring a kernel without Mediatek SoC
> > support.
> >
> > Fixes: 6746cc858259985a ("ASoC: mediatek: mt8195: add platform
> > driver")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> >  sound/soc/mediatek/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/sound/soc/mediatek/Kconfig b/sound/soc/mediatek/Kconfig
> > index cf567a89f421b4c0..c8c815f599da90bf 100644
> > --- a/sound/soc/mediatek/Kconfig
> > +++ b/sound/soc/mediatek/Kconfig
> > @@ -187,6 +187,7 @@ config SND_SOC_MT8192_MT6359_RT1015_RT5682
> >
> >  config SND_SOC_MT8195
> >       tristate "ASoC support for Mediatek MT8195 chip"
> > +     depends on ARCH_MEDIATEK || COMPILE_TEST
> >       select SND_SOC_MEDIATEK
> >       help
> >         This adds ASoC platform driver support for Mediatek MT8195
> > chip
>
> Hi Geert,
>
> Thanks for your patch first.
> I really missed the dependency declaration.
> But we only test "depends on ARCH_MEDIATEK" internally, maybe removing
> "COMPILE_TEST" like other MTK series is better for the maintenance in
> the future.

If the driver compiles with CONFIG_ARCH_MEDIATEK=n, it is better
to enable compile-testing, as that may catch issues.\
I didn't change the existing MTK symbols, only new symbols.
(adding missing dependencies to existing symbols is in my (huge) backlog ;-)

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ASoC: mediatek: SND_SOC_MT8195 should depend on ARCH_MEDIATEK
  2021-08-31 13:18 [PATCH] ASoC: mediatek: SND_SOC_MT8195 should depend on ARCH_MEDIATEK Geert Uytterhoeven
  2021-09-01  3:48 ` Trevor Wu
@ 2021-09-01 18:14 ` Mark Brown
  1 sibling, 0 replies; 4+ messages in thread
From: Mark Brown @ 2021-09-01 18:14 UTC (permalink / raw)
  To: Liam Girdwood, Trevor Wu, Geert Uytterhoeven
  Cc: Mark Brown, Matthias Brugger, linux-kernel, Jaroslav Kysela,
	linux-mediatek, Takashi Iwai, linux-arm-kernel, alsa-devel

On Tue, 31 Aug 2021 15:18:54 +0200, Geert Uytterhoeven wrote:
> The Mediatek MT8195 sound hardware is only present on Mediatek MT8195
> SoCs.  Hence add a dependency on ARCH_MEDIATEK, to prevent asking the
> user about this driver when configuring a kernel without Mediatek SoC
> support.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: mediatek: SND_SOC_MT8195 should depend on ARCH_MEDIATEK
      commit: 940ffa19454704ca2ecd23b0d8dd604c93421bfa

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-09-01 18:15 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-31 13:18 [PATCH] ASoC: mediatek: SND_SOC_MT8195 should depend on ARCH_MEDIATEK Geert Uytterhoeven
2021-09-01  3:48 ` Trevor Wu
2021-09-01  7:14   ` Geert Uytterhoeven
2021-09-01 18:14 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).