LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH v2] arm64: dts: mt8173: elm: Use aliases to mmc nodes
@ 2021-07-26 10:24 Hsin-Yi Wang
  2021-07-26 10:40 ` Chen-Yu Tsai
  2021-08-04 15:49 ` Matthias Brugger
  0 siblings, 2 replies; 3+ messages in thread
From: Hsin-Yi Wang @ 2021-07-26 10:24 UTC (permalink / raw)
  To: Matthias Brugger
  Cc: Rob Herring, Enric Balletbo Serra, eizan, devicetree,
	linux-arm-kernel, linux-mediatek, linux-kernel

Use aliases to mmc nodes so the partition name for eMMC and SD card will
be consistent across boots.

Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
v1->v2: skip unused mmc2.
---
 arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
index 21452c51a20a8..d5a2cad39c9c7 100644
--- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
@@ -10,6 +10,12 @@
 #include "mt8173.dtsi"
 
 / {
+	aliases {
+		mmc0 = &mmc0;
+		mmc1 = &mmc1;
+		mmc2 = &mmc3;
+	};
+
 	memory@40000000 {
 		device_type = "memory";
 		reg = <0 0x40000000 0 0x80000000>;
-- 
2.32.0.432.gabb21c7263-goog


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] arm64: dts: mt8173: elm: Use aliases to mmc nodes
  2021-07-26 10:24 [PATCH v2] arm64: dts: mt8173: elm: Use aliases to mmc nodes Hsin-Yi Wang
@ 2021-07-26 10:40 ` Chen-Yu Tsai
  2021-08-04 15:49 ` Matthias Brugger
  1 sibling, 0 replies; 3+ messages in thread
From: Chen-Yu Tsai @ 2021-07-26 10:40 UTC (permalink / raw)
  To: Hsin-Yi Wang
  Cc: Matthias Brugger, Rob Herring, Enric Balletbo Serra,
	Eizan Miyamoto, Devicetree List,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	moderated list:ARM/Mediatek SoC support, LKML

Hi,

On Mon, Jul 26, 2021 at 6:25 PM Hsin-Yi Wang <hsinyi@chromium.org> wrote:
>
> Use aliases to mmc nodes so the partition name for eMMC and SD card will
> be consistent across boots.

To be honest I think this deserves a bit more pretext:

There used to be no way to specify the order of MMC controllers, and
the numbering was based on how the implementations added the devices.
For Linux, this changed when asynchronous probing was enabled for most
drivers, resulting in mmc device numbers jumping around.

With commit 1796164fac7e ("dt-bindings: mmc: document alias support"),
a way to specify fixed index numbers was provided.


Otherwise,

Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>

Same for the mt8183-kukui patch.


> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> ---
> v1->v2: skip unused mmc2.
> ---
>  arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> index 21452c51a20a8..d5a2cad39c9c7 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> @@ -10,6 +10,12 @@
>  #include "mt8173.dtsi"
>
>  / {
> +       aliases {
> +               mmc0 = &mmc0;
> +               mmc1 = &mmc1;
> +               mmc2 = &mmc3;
> +       };
> +
>         memory@40000000 {
>                 device_type = "memory";
>                 reg = <0 0x40000000 0 0x80000000>;
> --
> 2.32.0.432.gabb21c7263-goog
>
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] arm64: dts: mt8173: elm: Use aliases to mmc nodes
  2021-07-26 10:24 [PATCH v2] arm64: dts: mt8173: elm: Use aliases to mmc nodes Hsin-Yi Wang
  2021-07-26 10:40 ` Chen-Yu Tsai
@ 2021-08-04 15:49 ` Matthias Brugger
  1 sibling, 0 replies; 3+ messages in thread
From: Matthias Brugger @ 2021-08-04 15:49 UTC (permalink / raw)
  To: Hsin-Yi Wang
  Cc: Rob Herring, Enric Balletbo Serra, eizan, devicetree,
	linux-arm-kernel, linux-mediatek, linux-kernel



On 26/07/2021 12:24, Hsin-Yi Wang wrote:
> Use aliases to mmc nodes so the partition name for eMMC and SD card will
> be consistent across boots.
> 
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>

applied to v5.14-next/dts64

Thanks

> ---
> v1->v2: skip unused mmc2.
> ---
>  arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> index 21452c51a20a8..d5a2cad39c9c7 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> @@ -10,6 +10,12 @@
>  #include "mt8173.dtsi"
>  
>  / {
> +	aliases {
> +		mmc0 = &mmc0;
> +		mmc1 = &mmc1;
> +		mmc2 = &mmc3;
> +	};
> +
>  	memory@40000000 {
>  		device_type = "memory";
>  		reg = <0 0x40000000 0 0x80000000>;
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-08-04 15:49 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-26 10:24 [PATCH v2] arm64: dts: mt8173: elm: Use aliases to mmc nodes Hsin-Yi Wang
2021-07-26 10:40 ` Chen-Yu Tsai
2021-08-04 15:49 ` Matthias Brugger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).