From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC458C3F2D8 for ; Mon, 2 Mar 2020 17:01:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9047E222C4 for ; Mon, 2 Mar 2020 17:01:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="G//D/RNJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727385AbgCBRBZ (ORCPT ); Mon, 2 Mar 2020 12:01:25 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:44575 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727111AbgCBRBX (ORCPT ); Mon, 2 Mar 2020 12:01:23 -0500 Received: by mail-wr1-f67.google.com with SMTP id n7so590199wrt.11 for ; Mon, 02 Mar 2020 09:01:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=JxxZMXsVW1OlUAj2yQJ6ZF+K072kLAsn2WXP+512A/M=; b=G//D/RNJf7ItaCMkYYyhrVVoLHbmg+VdXhMwiw86M2PluaUELtampqk8xrbWLKMLqe wDF6bck4vxs+t2ye9djT5PqWyAngPJSwNSuWytRndAweD5E9TdzAcOMNjOpOyQNtZZZg r7vL6QxW0b3sBA7umhlOFOrPG88rJermRECnzifaNjrCU0zarr6CZ6TLwVTnV4KbC7Dz KKCLPYE2Dbc/TUsbpqgaCjNK+2s1i2B07rTF8WBiOaoSBJ93SrGx7UA6IdL5G6Z1Qdsj uktYR5gQeIpnWGXqf4kRgvEeN+l3bmxU2AD9cznl/S5X2ZM5XmTsbVcBGYTB9Wc/54/p +mVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=JxxZMXsVW1OlUAj2yQJ6ZF+K072kLAsn2WXP+512A/M=; b=oC0FGNafmeZHzSmZkEeLKjDyc2smsnNq7wLN9yJKShICGRfMgF8aMMsj1gmC8BHcGV ipITfwOon1QAEHrqNuKO+D/i2O5mSZOZyOrenW3jEZJGxgwBM7+5qQTsxN9a7pUmnuC4 ZPtzLmJS9ARh/gae0vjYgqKIibbEz9yyreG7WVfqD1MDtt2XigqmepNBEv7K/FNbx9yG 1+4sxsKLhEL2rE4zZi3ybegy2Qj8r/BZl6zfuzLCp8N1P8toxpJxYgDpXbcE+1YN98hO tWYb+yEa5fkxcADXijen/OKj1Va2cMY+ejdYXcDuvra1rhV/jzZh0qROXJ0qIkPDcesS cS6g== X-Gm-Message-State: ANhLgQ30jEUhkQaimR/aNkfBJrKm2yw4ehVXHU19dzotDmz0//fouHWt J4RvuqzpymshEh8txoc6K855FA== X-Google-Smtp-Source: ADFU+vvbCDhbjKnBTJ0P9gUMwbINUDb4htWjCWs1X4yIjcZsa/sq2I2rF81VVO4nPsuCrCG5FapnZA== X-Received: by 2002:adf:df8f:: with SMTP id z15mr533884wrl.184.1583168481691; Mon, 02 Mar 2020 09:01:21 -0800 (PST) Received: from localhost (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.gmail.com with ESMTPSA id p10sm23628037wrx.81.2020.03.02.09.01.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 02 Mar 2020 09:01:21 -0800 (PST) From: Kevin Hilman To: Anand Moon , Rob Herring , Mark Rutland , Neil Armstrong , Martin Blumenstingl , Jerome Brunet , Michael Turquette , Stephen Boyd Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [PATCHv2 2/2] clk: meson: g12a: set cpub_clk flags to CLK_IS_CRITICAL In-Reply-To: <20200302125310.742-3-linux.amoon@gmail.com> References: <20200302125310.742-1-linux.amoon@gmail.com> <20200302125310.742-3-linux.amoon@gmail.com> Date: Mon, 02 Mar 2020 18:01:20 +0100 Message-ID: <7hlfoir8rj.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Anand Moon writes: > On Odroid n2, cpub_clk is not geting enable, which lead the stalling > at booting of the device, First, how is the CPU_B clk related to the SD card issue described in the cover letter? I think this patch is attempting to fix something unrelated to the SD card. Please separate from this series (or describe in detail how it's related to the SD card booting.) Also, we're missing lots of details here to be able to help. Are you using the u-boot from hardkernel? your own? something else? What's the version? Can you share logs (including u-boot logs) showing how your kernel is booting and full kernel boot log (including the stalls.) > updating flags to CLK_IS_CRITICAL which help enable all the parent for > cpub_clk. With current mainline, I've tested DVFS using CPUfreq on both clusters on odroid-n2, and both clusters are booting, so I don't understand the need for this patch. It's not related to your problem (I don't think) but for the regulators used by each cluster, the PWM driver is needed, and there's a bug/race in the probing of the PWM regulators used for CPU_B. If you make the PWM regulators, built-in this problem goes away for CPUfreq. Just for kicks, can you build your kernel with CONFIG_PWM_MESON=y (currently defaults to =n) and see if you have any better results with booting. And FYI, any use of CLK_IS_CRITICAL will be very highly scrutinized. You will need detailed justification for adding this flag since it most often is just masking some other bug. Kevin > Fixes: ffae8475b90c (clk: meson: g12a: add notifiers to handle cpu clock change); > Cc: Martin Blumenstingl > Cc: Jerome Brunet > Cc: Neil Armstrong > Suggested-by: Neil Armstrong > Signed-off-by: Anand Moon > --- > Previous changes > fix the commit $subject and $message as previously I was > wrong on the my findings. > Added the Fixed tags to the commit. > > Following Neil's suggestion, I have prepared this patch. > https://patchwork.kernel.org/patch/11177441/#22964889 > --- > drivers/clk/meson/g12a.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/meson/g12a.c b/drivers/clk/meson/g12a.c > index d2760a021301..7237d08b4112 100644 > --- a/drivers/clk/meson/g12a.c > +++ b/drivers/clk/meson/g12a.c > @@ -681,7 +681,7 @@ static struct clk_regmap g12b_cpub_clk = { > &g12a_sys_pll.hw > }, > .num_parents = 2, > - .flags = CLK_SET_RATE_PARENT, > + .flags = CLK_SET_RATE_PARENT | CLK_IS_CRITICAL, > }, > }; > > -- > 2.25.1