From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754529AbbCIUoH (ORCPT ); Mon, 9 Mar 2015 16:44:07 -0400 Received: from mail-pa0-f52.google.com ([209.85.220.52]:46979 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754105AbbCIUoC (ORCPT ); Mon, 9 Mar 2015 16:44:02 -0400 From: Kevin Hilman To: Sascha Hauer Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Matthias Brugger , linux-mediatek@lists.infradead.org, kernel@pengutronix.de Subject: Re: [RFC] Mediatek SCPSYS power domain support References: <1425888603-25800-1-git-send-email-s.hauer@pengutronix.de> Date: Mon, 09 Mar 2015 13:43:57 -0700 In-Reply-To: <1425888603-25800-1-git-send-email-s.hauer@pengutronix.de> (Sascha Hauer's message of "Mon, 9 Mar 2015 09:09:59 +0100") Message-ID: <7hoao16gvm.fsf@deeprootsystems.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sascha Hauer writes: > s series adds support for the MediaTek SCPSYS unit. > > The SCPSYS unit handles several power management related tasks such > as thermal measurement, DVFS, interrupt filter and low level sleep > control. > > The initial support only contains the generic power domain handling. > This is needed to turn on power to the different power domains. > > The driver is quite straight forward now. Due to the lack of a better > place I have put it to drivers/soc/mediatek. As the SCPSYS unit has > several other tasks that also do not fit into some specific subsystem > this probably is a good place for this driver. > > What is not clear to me is how the Kconfig dependencies should be > handled. Some domains are disabled by bootloader default, so without > this driver for example sound won't work. So should PM, PM_GENERIC_DOMAINS > and this driver be made mandatory for MT8173? Or should this driver > when PM is disabled be compiled as a stub which only enables all > domains? I don't have a good idea how things should work out here. IMO, a stub that enables all the domains is what you want. Kevin