LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Harald Arnesen" <skogtun.linux@gmail.com>
To: "Linus Torvalds" <torvalds@linux-foundation.org>
Cc: "Harald Arnesen" <skogtun.harald@gmail.com>,
	"FUJITA Tomonori" <tomof@acm.org>,
	akpm@linux-foundation.org, matthew@wil.cx,
	linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
	fujita.tomonori@lab.ntt.co.jp
Subject: Re: Latest git oopses during boot
Date: Thu, 7 Feb 2008 23:24:00 +0100	[thread overview]
Message-ID: <8120cfd40802071424h5cf04861x63a88ea18508eda9@mail.gmail.com> (raw)
In-Reply-To: <alpine.LFD.1.00.0802071404400.2896@woody.linux-foundation.org>

On 2/7/08, Linus Torvalds <torvalds@linux-foundation.org> wrote:
>
>
> On Thu, 7 Feb 2008, Harald Arnesen wrote:
> >
> > I'll try applying the patch to a freshly downloaded git-tree.
>
> Ok, good.
>
> > Shall I try another compiler? I have at least these two:
> >
> > gcc version 3.4.6 (Ubuntu 3.4.6-6ubuntu2)
> > gcc version 4.1.3 20070929 (prerelease) (Ubuntu 4.1.2-16ubuntu2)
>
> I would suggest a patch mis-application problem first (or possibly even
> the patch itself being broken - I simply didn't look very closely at the
> patch, but it *looked* ok).
>
> If it's a compiler bug, it's a pretty big one, and quite frankly, I doubt
> it. Compiler bugs do happen, but they are pretty rare, and they tend to
> have more subtle effects than the one you see.
>
> However:
>
> > in addition to the self-compiled 4.2.3 I used for the tests.
>
> 4.2.3? Really? That's pretty damn recent, and so almost totally untested.
> That does make a compiler bug at least more likely.
>
> So yes, if you already have other compilers installed, you should try
> them. If it really is a compiler bug, it's a really bad one, and you would
> want to let the gcc people know.
>
> Still, I'd double-check that the
>
>         asc_dvc_varp->overrun_buf = kzalloc(ASC_OVERRUN_BSIZE, GFP_KERNEL);
>
> line was added properly first. You should see it way after the point where
> it did
>
>         asc_dvc_varp = &boardp->dvc_var.asc_dvc_var;
>
> to initialize it (and both statements should be inside a
>
>         if (ASC_NARROW_BOARD(boardp)) {
>
> conditional - please check that the source code looks sane too).
>
>                         Linus

I just re-downloaded an re-patched and re-compiled (with gcc 4.2.3),
and now the kernel boots. I must have screwed up the previous
patching.

It now works, with Fujita's patch applied.
-- 
Hilsen Harald

  reply	other threads:[~2008-02-07 22:24 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-06 16:32 Harald Arnesen
2008-02-06 22:47 ` Andrew Morton
     [not found]   ` <8120cfd40802070144l79830c2cs6329c302697ecc8b@mail.gmail.com>
2008-02-07 10:02     ` Andrew Morton
2008-02-07 11:14       ` Harald Arnesen
2008-02-07 11:16         ` Christoph Hellwig
2008-02-07 14:32         ` FUJITA Tomonori
     [not found]           ` <8120cfd40802070933r42a98537v78feb7ee8e748a94@mail.gmail.com>
2008-02-07 18:18             ` Linus Torvalds
     [not found]               ` <8120cfd40802071248x20ed938dh52cd9e314219613b@mail.gmail.com>
2008-02-07 21:14                 ` Linus Torvalds
2008-02-07 21:39                   ` Harald Arnesen
2008-02-07 22:12                     ` Linus Torvalds
2008-02-07 22:24                       ` Harald Arnesen [this message]
2008-02-08  0:10                         ` FUJITA Tomonori
2008-02-06 23:06 ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8120cfd40802071424h5cf04861x63a88ea18508eda9@mail.gmail.com \
    --to=skogtun.linux@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=fujita.tomonori@lab.ntt.co.jp \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=skogtun.harald@gmail.com \
    --cc=tomof@acm.org \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: Latest git oopses during boot' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).