LKML Archive on
help / color / mirror / Atom feed
From: "Parag Warudkar" <>
To: "Jean Delvare" <>
Cc: LKML <>,
	"Ingo Molnar" <>,
	"Thomas Gleixner" <>
Subject: Re: [PATCH] dmi: Prevent linked list corruption (resent)
Date: Mon, 11 Feb 2008 12:35:39 -0500	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <20080211182440.071c47d9@hyperion.delvare>

On Feb 11, 2008 12:24 PM, Jean Delvare <> wrote:
> [Once more without forgetting the last "quilt refresh", sorry.]
> Adding the same item to a given linked list more than once is guaranteed
> to break and corrupt the list. This is however what we do in dmi_scan
> since commit 79da4721117fcf188b4b007b775738a530f574da.
> Given that there is absolutely no interest in saving empty OEM
> strings anyway, I propose the simple and efficient fix below: we
> discard the empty OEM strings altogether.
> Signed-off-by: Jean Delvare <>
> Cc: Parag Warudkar <>
> Cc: Ingo Molnar <>
> Cc: Thomas Gleixner <>

I suppose the list would be corrupted only if there are deletions from
the list? (Which there aren't.)

Anyway not adding the empty strings is way better and I don't see now
how they could've been useful.
(I added them out of the doubt of breaking something.)

Acked-By: Parag Warudkar <>



  reply	other threads:[~2008-02-11 17:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-11 17:22 [PATCH] dmi: Prevent linked list corruption Jean Delvare
2008-02-11 17:24 ` [PATCH] dmi: Prevent linked list corruption (resent) Jean Delvare
2008-02-11 17:35   ` Parag Warudkar [this message]
2008-02-11 17:53     ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \
    --subject='Re: [PATCH] dmi: Prevent linked list corruption (resent)' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).