LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Wappler Marcel" <Marcel.Wappler@bridgeco.net>
To: "Patrick McHardy" <kaber@trash.net>
Cc: <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
	<davem@davemloft.net>, <ebiederman@lnxi.com>
Subject: RE: [PATCH] [resend]The kernel gets no IP from some DHCP servers, 2.6.24
Date: Wed, 27 Feb 2008 14:11:55 +0100	[thread overview]
Message-ID: <83116F0A4FF67A4F97BA0B6E408C48E301C5CE08@zuerich.BC-Int.NET> (raw)
In-Reply-To: <47C55BBF.7080501@trash.net>

-----Original Message-----
>>  #include <linux/types.h>
>> @@ -103,6 +107,7 @@
>>  					   - '3' from resolv.h */
>>  
>>  #define NONE __constant_htonl(INADDR_NONE)
>> +#define ZERO __constant_htonl(((unsigned long int) 0x00000000))
>This should probably use INADDR_ANY.
My first try went in this direction. But at a second look I thought
that the names ANY (255.255.255.255) and NONE (0.0.0.0) are indirect
leading to confusion. The interpretation of the zero addresses in
the DHCPDISCOVER packet is in the kind of 'no address' and not of
'any addressee'. So the meaning and usage of INADDR_ANY and ZERO
may be totally different in this file.
In my opinion it is necessary to distinguish between INADDR_ANY
and the ZERO address which ist requested to be in the DHCPDISCOVER
packet.

Marcel
--
Marcel Wappler
Bridgeco AG
CH-8600 Dübendorf
Switzerland

  reply	other threads:[~2008-02-27 13:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-27 12:23 Wappler Marcel
2008-02-27 12:46 ` Patrick McHardy
2008-02-27 13:11   ` Wappler Marcel [this message]
2008-02-27 16:38     ` Stephen Hemminger
2008-02-27 17:25       ` Wappler Marcel
2008-02-27 19:13 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83116F0A4FF67A4F97BA0B6E408C48E301C5CE08@zuerich.BC-Int.NET \
    --to=marcel.wappler@bridgeco.net \
    --cc=davem@davemloft.net \
    --cc=ebiederman@lnxi.com \
    --cc=kaber@trash.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --subject='RE: [PATCH] [resend]The kernel gets no IP from some DHCP servers, 2.6.24' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).