From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13F0DC4338F for ; Fri, 13 Aug 2021 01:44:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E5704610CC for ; Fri, 13 Aug 2021 01:44:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238267AbhHMBon (ORCPT ); Thu, 12 Aug 2021 21:44:43 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:48897 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238130AbhHMBol (ORCPT ); Thu, 12 Aug 2021 21:44:41 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1628819055; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=yKB585e+W6FgF524wGRfYxwHeT/TqmQJg/xn/cG/j0Y=; b=dbXTaWZBFWC+5H331uwM9jeCOAwyVktTwdQxRAsVIe33D7wikszMIrcjEuY1TVINXpGzRLQ6 L/bH6s2YSdEbqnTUjhNtMOfOJplFV1iU5/39OnAYUgUKiH4Ovh/pgwCbMEpYitiKwT3vJepn LKjhjnBZCjlQVOPUEr51/yyZrhI= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-west-2.postgun.com with SMTP id 6115ce61b14e7e2ecb67cbfc (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 13 Aug 2021 01:44:01 GMT Sender: wat=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 2693CC433D3; Fri, 13 Aug 2021 01:44:01 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: wat) by smtp.codeaurora.org (Postfix) with ESMTPSA id 69100C4338A; Fri, 13 Aug 2021 01:44:00 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 13 Aug 2021 09:44:00 +0800 From: wat@codeaurora.org To: Mathias Nyman , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Cc: quic_wat@quicinc.com, wat@codeaurora.org Subject: Re: [PATCH] usb: xhci-ring: USB SSD may fail to unmount if disconnect during data transferring. In-Reply-To: <1628769727-45046-1-git-send-email-wat@codeaurora.org> References: <1628769727-45046-1-git-send-email-wat@codeaurora.org> Message-ID: <83812530fbe1ba6f93c0978019bf118b@codeaurora.org> X-Sender: wat@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi usb teams, I have a patch about xhci-ring, can you help me to check? you can contact me if you have any question. On 2021-08-12 20:02, Tao Wang wrote: > From: Tao Wang > > it stuck in usb_kill_urb() due to urb use_count will not become zero, > this means urb giveback is not happen. > in xhci_handle_cmd_set_deq() will giveback urb if td's cancel_status > equal to TD_CLEARING_CACHE, > but in xhci_invalidate_cancelled_tds(), only last canceled td's > cancel_status change to TD_CLEARING_CACHE, > thus giveback only happen to last urb. > > this change set all cancelled_td's cancel_status to TD_CLEARING_CACHE > rather than the last one, so all urb can giveback. > > Signed-off-by: Tao Wang > --- > drivers/usb/host/xhci-ring.c | 24 ++++++++++++------------ > 1 file changed, 12 insertions(+), 12 deletions(-) > > diff --git a/drivers/usb/host/xhci-ring.c > b/drivers/usb/host/xhci-ring.c > index 8fea44b..c7dd7c0 100644 > --- a/drivers/usb/host/xhci-ring.c > +++ b/drivers/usb/host/xhci-ring.c > @@ -960,19 +960,19 @@ static int xhci_invalidate_cancelled_tds(struct > xhci_virt_ep *ep) > td_to_noop(xhci, ring, td, false); > td->cancel_status = TD_CLEARED; > } > - } > - if (cached_td) { > - cached_td->cancel_status = TD_CLEARING_CACHE; > - > - err = xhci_move_dequeue_past_td(xhci, slot_id, ep->ep_index, > - cached_td->urb->stream_id, > - cached_td); > - /* Failed to move past cached td, try just setting it noop */ > - if (err) { > - td_to_noop(xhci, ring, cached_td, false); > - cached_td->cancel_status = TD_CLEARED; > + if (cached_td) { > + cached_td->cancel_status = TD_CLEARING_CACHE; > + > + err = xhci_move_dequeue_past_td(xhci, slot_id, ep->ep_index, > + cached_td->urb->stream_id, > + cached_td); > + /* Failed to move past cached td, try just setting it noop */ > + if (err) { > + td_to_noop(xhci, ring, cached_td, false); > + cached_td->cancel_status = TD_CLEARED; > + } > + cached_td = NULL; > } > - cached_td = NULL; > } > return 0; > }