LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Icenowy Zheng <icenowy@aosc.io>
To: Andre Przywara <andre.przywara@arm.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Maxime Ripard <maxime.ripard@bootlin.com>,
Chen-Yu Tsai <wens@csie.org>
Cc: linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
Subject: Re: [linux-sunxi] [PATCH 3/3] arm64: allwinner: h6: enable MMC0/2 on Pine H64
Date: Fri, 27 Apr 2018 15:12:42 +0800 [thread overview]
Message-ID: <83EDF187-5EB2-4FEB-99BC-9D5B728D3A45@aosc.io> (raw)
In-Reply-To: <03cc2e8c-4a35-3fb4-b408-fd8d4ba3e407@arm.com>
于 2018年4月27日 GMT+08:00 上午12:46:26, Andre Przywara <andre.przywara@arm.com> 写到:
>Hi,
>
>On 26/04/18 15:07, Icenowy Zheng wrote:
>> The Pine H64 board have a MicroSD slot connected to MMC0 controller
>of
>> the H6 SoC and a eMMC slot connected to MMC2.
>>
>> Enable them in the device tree.
>>
>> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
>> ---
>> .../boot/dts/allwinner/sun50i-h6-pine-h64.dts | 32
>++++++++++++++++++++++
>> 1 file changed, 32 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts
>b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts
>> index d36de5eb81f3..78b1cd54687c 100644
>> --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts
>> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts
>> @@ -20,6 +20,38 @@
>> chosen {
>> stdout-path = "serial0:115200n8";
>> };
>> +
>> + reg_vcc3v3: vcc3v3 {
>> + compatible = "regulator-fixed";
>> + regulator-name = "vcc3v3";
>> + regulator-min-microvolt = <3300000>;
>> + regulator-max-microvolt = <3300000>;
>> + };
>> +
>> + reg_vcc1v8: vcc1v8 {
>> + compatible = "regulator-fixed";
>> + regulator-name = "vcc1v8";
>> + regulator-min-microvolt = <1800000>;
>> + regulator-max-microvolt = <1800000>;
>> + };
>> +};
>> +
>> +&mmc0 {
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&mmc0_pins>;
>> + vmmc-supply = <®_vcc3v3>;
>
>So this is actually CLDO1 on the AXP, correct?
I remember it's coupled between two LDOs, to provide enough power.
>
>
>> + cd-gpios = <&pio 5 6 GPIO_ACTIVE_LOW>;
>> + status = "okay";
>> +};
>> +
>> +&mmc2 {
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&mmc2_pins>;
>> + vmmc-supply = <®_vcc3v3>;
>> + vqmmc-supply = <®_vcc1v8>;
>
>And this is BLDO2?
Yes.
>
>I am just asking because I want to avoid running into the same problem
>as with the A64 before: that future DTs become incompatible with older
>kernels, because we change the power supply to point to the AXP
>regulators, which this kernel does not support yet.
The answer is just not to keep this compatibility, as it's not
supported option to update DT without updating kernel.
P.S. I think the DT will update twice on the kernel side, the
first time keep reg_vcc3v3 (as it's coupled) but use real
regulator for reg_vcc1v8, the second time use the real
coupled regulator for reg_vcc3v3.
>
>It looks like there are more users of those power rails, so we could
>keep those supplies connected to these fixed regulators here, even with
>AXP-805 support in the kernel.
It's not a good choice.
>
>Or we keep this back until we get proper AXP support in the kernel? I
>guess it's quite close to the existing PMICs, so it might be more a
>copy&paste exercise to support the AXP-805?
It's not a reason to keep it back.
>
>But apart from this this looks correct to me.
>
>Cheers,
>Andre.
>
>> + non-removable;
>> + cap-mmc-hw-reset;
>> + status = "okay";
>> };
>>
>> &uart0 {
>>
next prev parent reply other threads:[~2018-04-27 7:13 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-26 14:07 [PATCH 0/3] Enable basic MMC support on Allwinner H6 Icenowy Zheng
2018-04-26 14:07 ` [PATCH 1/3] mmc: sunxi: add support for the MMC controller on H6 Icenowy Zheng
2018-04-26 16:45 ` [linux-sunxi] " Andre Przywara
2018-04-27 8:38 ` Icenowy Zheng
2018-04-27 9:23 ` Andre Przywara
2018-05-02 12:54 ` Ulf Hansson
2018-04-26 14:07 ` [PATCH 2/3] arm64: allwinner: h6: add device tree nodes for MMC controllers Icenowy Zheng
2018-04-26 16:45 ` [linux-sunxi] " Andre Przywara
2018-04-27 8:36 ` Icenowy Zheng
2018-04-27 9:18 ` Andre Przywara
2018-04-27 9:23 ` Icenowy Zheng
2018-04-27 21:25 ` André Przywara
2018-06-26 0:28 ` Icenowy Zheng
2018-04-26 14:07 ` [PATCH 3/3] arm64: allwinner: h6: enable MMC0/2 on Pine H64 Icenowy Zheng
2018-04-26 16:46 ` [linux-sunxi] " Andre Przywara
2018-04-27 7:12 ` Icenowy Zheng [this message]
2018-04-30 9:47 ` Andre Przywara
2018-04-30 9:51 ` Icenowy Zheng
2018-04-30 10:44 ` Andre Przywara
2018-05-01 15:52 ` Chen-Yu Tsai
2018-05-02 11:01 ` Andre Przywara
2018-05-04 2:44 ` Chen-Yu Tsai
2018-05-01 15:48 ` Chen-Yu Tsai
2018-05-02 9:36 ` Maxime Ripard
2018-05-02 11:01 ` Andre Przywara
2018-05-03 18:05 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83EDF187-5EB2-4FEB-99BC-9D5B728D3A45@aosc.io \
--to=icenowy@aosc.io \
--cc=andre.przywara@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=maxime.ripard@bootlin.com \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=wens@csie.org \
--subject='Re: [linux-sunxi] [PATCH 3/3] arm64: allwinner: h6: enable MMC0/2 on Pine H64' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).