LKML Archive on
help / color / mirror / Atom feed
From: "Pekka Enberg" <>
To: "Nick Piggin" <>
Cc: "Mathieu Desnoyers" <>,
	"Christoph Lameter" <>,
Subject: Re: [RFC PATCH] Implement slub fastpath with sequence number
Date: Tue, 11 Mar 2008 16:45:48 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Hi Nick,

On Tue, Mar 11, 2008 at 11:41 AM, Nick Piggin <> wrote:
>  Wow. I applaud the effort to micro optimise things ;)
>  But I hope this doesn't get merged until macro-regressions in SLUB
>  are verified to be fixed. It's pretty clear that SLUB's problem is
>  not fastpath performance, so I think this would be premature
>  optimisation.

What regressions are you referring to? The SLAB_HWCACHE_ALIGN
regression patch you sent is being merged. What else?

And FWIW, I don't like the patch because it makes the code very hairy.
But I don't see why we shouldn't merge SLUB fast-path optimizations if
they're clean and you have the numbers to show it's a gain even if
there are other remaining regressions.

  reply	other threads:[~2008-03-11 14:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-11  9:31 Mathieu Desnoyers
2008-03-11  9:41 ` Nick Piggin
2008-03-11 14:45   ` Pekka Enberg [this message]
2008-03-11 23:13     ` Nick Piggin
2008-03-12  4:14       ` Christoph Lameter
2008-03-11 14:34 ` Peter Zijlstra
2008-03-12  4:15   ` Christoph Lameter
2008-03-12 22:17   ` Mathieu Desnoyers
2008-03-13  1:20     ` Mathieu Desnoyers
2008-03-13  1:35       ` Mathieu Desnoyers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \
    --subject='Re: [RFC PATCH] Implement slub fastpath with sequence number' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).