LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Yisheng Xie <xieyisheng1@huawei.com>
To: Robin Murphy <robin.murphy@arm.com>, <will.deacon@arm.com>,
	<joro@8bytes.org>
Cc: <linux-arm-kernel@lists.infradead.org>,
	<iommu@lists.linux-foundation.org>,
	<linux-kernel@vger.kernel.org>, <liubo95@huawei.com>,
	<dingtianhong@huawei.com>
Subject: Re: [RFC 1/2] iommu/arm-smmu-v3: Remove bypass in arm_smmu_reset_device
Date: Tue, 24 Apr 2018 19:57:06 +0800	[thread overview]
Message-ID: <85c3b7d4-19c0-ea9c-b698-18e199b1da6d@huawei.com> (raw)
In-Reply-To: <9e2f8646-482a-e721-d1b6-e674de48e276@arm.com>

Hi Robin,

Thanks for your comment!
On 2018/4/24 0:07, Robin Murphy wrote:
> On 23/04/18 12:45, Yisheng Xie wrote:
>> Add a bypass parameter in arm_smmu_device to keep whether smmu device
>> should pypass or not, so parameter bypass in arm_smmu_reset_device can
>> be removed.
> 
> Given that the GBPA configuration implied by the bypass argument here
> is only there to avoid initialising a full stream table when the firmware
> is terminally broken, I wonder if it would make sense to simply skip
> allocating a stream table at all in that case. Then we could just base
> the subsequent SMMUEN/GPBA decision on whether strtab_cfg.strtab is valid or not.
> 
Yes, it may save many memory, and should be care about not access strtab when attach
device or other similar scenario, anyway software can achieve this after move bypass
to struct arm_smmu_device.

Thanks
Yisheng
> Robin.
> 

  reply	other threads:[~2018-04-24 11:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-23 11:45 [RFC 0/2] iommu/arm-smmu-v3: Support software retention for pm_resume Yisheng Xie
2018-04-23 11:45 ` [RFC 1/2] iommu/arm-smmu-v3: Remove bypass in arm_smmu_reset_device Yisheng Xie
2018-04-23 16:07   ` Robin Murphy
2018-04-24 11:57     ` Yisheng Xie [this message]
2018-04-23 11:45 ` [RFC 2/2] iommu/arm-smmu-v3: Support software retention for pm_resume Yisheng Xie
2018-04-23 16:14   ` Robin Murphy
2018-04-24 11:56     ` Yisheng Xie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=85c3b7d4-19c0-ea9c-b698-18e199b1da6d@huawei.com \
    --to=xieyisheng1@huawei.com \
    --cc=dingtianhong@huawei.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=joro@8bytes.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liubo95@huawei.com \
    --cc=robin.murphy@arm.com \
    --cc=will.deacon@arm.com \
    --subject='Re: [RFC 1/2] iommu/arm-smmu-v3: Remove bypass in arm_smmu_reset_device' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).