LKML Archive on
help / color / mirror / Atom feed
From: "Abhishek Sagar" <>
To: "Masami Hiramatsu" <>
Cc: LKML <>,,,
	"Ingo Molnar" <>
Subject: Re: [PATCH 3/3] x86: WARN_ON breakpoints from .kprobes.text section
Date: Sun, 27 Jan 2008 21:03:58 +0530	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 1/27/08, Masami Hiramatsu <> wrote:
> Sorry, I can not understand what issue these patches can solve.
> The breakpoint which is inserted by external debugger will be checked by
> kprobe_handler() and be passed to other exception_notify_handlers.
> In that case, we don't need to warn it.
> I think current code is enough simple.

kprobe_handler has a blanket check for all non-kprobe breakpoints.
They're all left to the kernel to handle. This is fine. Although
external debuggers are free to plant breakpoints anywhere, they should
be discouraged from doing so inside .kprobes.text region. Placing them
there may lead to recursive page-fault/trap handling. It's a defensive
check. I hope I've been able to clarify.

> --
> Masami Hiramatsu
> Software Engineer
> Hitachi Computer Products (America) Inc.
> Software Solutions Division
> e-mail:

Abhishek Sagar

  reply	other threads:[~2008-01-27 15:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-27  9:09 Abhishek Sagar
2008-01-27 14:28 ` Masami Hiramatsu
2008-01-27 15:33   ` Abhishek Sagar [this message]
2008-01-27 22:08     ` Masami Hiramatsu
2008-01-28 11:16       ` Abhishek Sagar
2008-01-28 17:22         ` Masami Hiramatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \
    --subject='Re: [PATCH 3/3] x86: WARN_ON breakpoints from .kprobes.text section' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).