LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Abhishek Sagar" <sagar.abhishek@gmail.com>
To: ananth@in.ibm.com
Cc: LKML <linux-kernel@vger.kernel.org>,
	jkenisto@us.ibm.com, "Masami Hiramatsu" <mhiramat@redhat.com>,
	"Ingo Molnar" <mingo@elte.hu>
Subject: Re: [PATCH 0/3][RFC] x86: Catch stray non-kprobe breakpoints
Date: Tue, 29 Jan 2008 22:54:46 +0530	[thread overview]
Message-ID: <863e9df20801290924n7a0794b8k4c334d0c78560db9@mail.gmail.com> (raw)
In-Reply-To: <20080129131821.GA27312@in.ibm.com>

On 1/29/08, Ananth N Mavinakayanahalli <ananth@in.ibm.com> wrote:
> > May be I'm completely off the mark here, but shouldn't a small subset
> > of this section simply be 'breakpoint-free' rather than 'kprobe-free'?
> > Placing a breakpoint on kprobe_handler (say) can loop into a recursive
> > trap without allowing the debugger's notifier chain to be invoked.
>
> A well heeled debugger will necessarily take care of saving contexts
> (using techniques like setjmp/longjmp, etc) to help it recover from such
> nested cases (See xmon for example).

Ok, but the protection/warning is not just for xmon.

> > I'm assuming that non-kprobe exception notifiers may (or even should) run
> > after kprobe's notifier callback (kprobe_exceptions_notify).
>
> Yes, any such notifier is invoked after kprobe's callback as the kprobe
> notifier is always registered with the highest priority.

Ok.

> > The WARN_ON (and not a BUG_ON) will be hit iff:
> > (in_kprobes_functions(addr) && !is_jprobe_bkpt(addr))
>
> But that still is unneeded dmesg clutter, IMHO.

Ok, a warning in my opinion would've been prudent since I think we
cannot guarantee non kprobe breakpoint users (debuggers or anything
else) from the recursive trap handling case.

> Ananth

--
Thanks,
Abhishek

  reply	other threads:[~2008-01-29 17:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-27  9:08 Abhishek Sagar
2008-01-29  6:02 ` Ananth N Mavinakayanahalli
2008-01-29 10:40   ` Abhishek Sagar
2008-01-29 13:18     ` Ananth N Mavinakayanahalli
2008-01-29 17:24       ` Abhishek Sagar [this message]
2008-01-29 15:13     ` Masami Hiramatsu
2008-01-29 18:08       ` Abhishek Sagar
2008-01-29 19:29         ` Masami Hiramatsu
2008-01-30  4:07           ` Ananth N Mavinakayanahalli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=863e9df20801290924n7a0794b8k4c334d0c78560db9@mail.gmail.com \
    --to=sagar.abhishek@gmail.com \
    --cc=ananth@in.ibm.com \
    --cc=jkenisto@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhiramat@redhat.com \
    --cc=mingo@elte.hu \
    --subject='Re: [PATCH 0/3][RFC] x86: Catch stray non-kprobe breakpoints' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).