LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Yinghai Lu" <yhlu.kernel@gmail.com>
To: "Jeff Garzik" <jeff@garzik.org>
Cc: "Muli Ben-Yehuda" <muli@il.ibm.com>, "Andi Kleen" <ak@suse.de>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	riku.seppala@kymp.net, "Andy Whitcroft" <apw@shadowen.org>,
	"Chuck Ebbert" <cebbert@redhat.com>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH/RFT] finish i386 and x86-64 sysdata conversion
Date: Sun, 5 Aug 2007 13:41:24 -0700	[thread overview]
Message-ID: <86802c440708051341q66aa1et3ea612beeab0f299@mail.gmail.com> (raw)
In-Reply-To: <46B60A93.80107@garzik.org>

On 8/5/07, Jeff Garzik <jeff@garzik.org> wrote:
> Yinghai Lu wrote:
> > pci_scan_bus_on_node(int bus, struct pci_ops *ops, int node)
> > x86_pci_scan_root_bus(int bus)
> > {
> >   pci_scan_bus_on_node(bus, &pci_root_ops, -1);
> > }
> >
> > i need node as one param for my patch later in irq.c and legacy.c
>
>
> It is a mistake to start coding NUMA details into pci scan functions.
>
> Anywhere the current code does not set the NUMA node, set it to -1 or
> some other default value.

Can you check
http://lkml.org/lkml/2007/7/26/377
http://lkml.org/lkml/2007/7/26/378
http://lkml.org/lkml/2007/7/26/379

it will make sure numa_node on device get correct value after pci scan.
esp for k8 system with second peer root bus on second node.

Thanks

Yinghai Lu

  reply	other threads:[~2007-08-05 20:41 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-03 22:10 Oops in 2.6.23-rc1-git9, arch/x86_64/pci/k8-bus.c::fill_mp_bus_to_cpumask() Chuck Ebbert
2007-08-03 22:50 ` Andrew Morton
2007-08-04  6:17   ` Muli Ben-Yehuda
2007-08-04  9:30   ` Andi Kleen
2007-08-04 16:32     ` Andrew Morton
2007-08-04 17:45       ` Yinghai Lu
2007-08-04 18:15         ` Andrew Morton
2007-08-04 19:02           ` Yinghai Lu
2007-08-05  5:52             ` Andrew Morton
2007-08-05  6:02               ` Muli Ben-Yehuda
2007-08-05  6:07                 ` Yinghai Lu
2007-08-05  6:11                   ` Muli Ben-Yehuda
2007-08-05  6:24                     ` Yinghai Lu
2007-08-05  6:27                       ` Yinghai Lu
2007-08-05  6:04               ` Yinghai Lu
2007-08-04 23:40       ` Andi Kleen
2007-08-05  4:15         ` Muli Ben-Yehuda
2007-08-05  4:33           ` Yinghai Lu
2007-08-05  5:00             ` Muli Ben-Yehuda
2007-08-05  4:31         ` Yinghai Lu
2007-08-05  5:04         ` Muli Ben-Yehuda
2007-08-05  5:38           ` Yinghai Lu
2007-08-05  7:53             ` [PATCH/RFT] finish i386 and x86-64 sysdata conversion Muli Ben-Yehuda
2007-08-05  8:49               ` Yinghai Lu
2007-08-05 11:54                 ` Muli Ben-Yehuda
2007-08-05 16:39                   ` Yinghai Lu
2007-08-05 17:36                     ` Jeff Garzik
2007-08-05 20:41                       ` Yinghai Lu [this message]
2007-08-07 22:49               ` Andrew Morton
2007-08-07 22:56                 ` Muli Ben-Yehuda
2007-08-08  0:43                   ` Jeff Garzik
2007-08-08  1:09                     ` Yinghai Lu
2007-08-08  1:21                       ` Jeff Garzik
2007-08-08  1:28                         ` Yinghai Lu
2007-08-08  2:59                         ` Yinghai Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86802c440708051341q66aa1et3ea612beeab0f299@mail.gmail.com \
    --to=yhlu.kernel@gmail.com \
    --cc=ak@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=apw@shadowen.org \
    --cc=cebbert@redhat.com \
    --cc=jeff@garzik.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=muli@il.ibm.com \
    --cc=riku.seppala@kymp.net \
    --subject='Re: [PATCH/RFT] finish i386 and x86-64 sysdata conversion' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).