LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Yinghai Lu" <yhlu.kernel@gmail.com>
To: "Balaji Rao" <balajirrao@gmail.com>
Cc: "Ingo Molnar" <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: hpet_late_init hang
Date: Wed, 16 Jan 2008 13:39:42 -0800	[thread overview]
Message-ID: <86802c440801161339h4e3e983co67e05a231666d050@mail.gmail.com> (raw)
In-Reply-To: <200801161404.33519.balajirrao@gmail.com>

On Jan 16, 2008 12:34 AM, Balaji Rao <balajirrao@gmail.com> wrote:
> On Wednesday 16 January 2008 12:21:33 pm Ingo Molnar wrote:
> Hi Ingo,
> > * Yinghai Lu <yhlu.kernel@gmail.com> wrote:
> > > "
> > > commit e5ed385fa0d6f35406e3e3ed75e5eb9adeb811df
> > > Author: Balaji Rao <balajirrao@gmail.com>
> > > Date:   Tue Jan 15 16:53:29 2008 +0100
> > >
> > >     Assign IRQs to HPET Timers
> > > "
> > > in x86.git
> > >
> > > cause my servers hang
> > > after
> > > Calling initcall 0xffffffff80b9a465: hpet_late_init+0x0/0x100()
..
> Looks like IRQ 31 is assigned to timer 3, even without the patch! I wonder who wrote the number 31. But the manual says
> that it is zero by default.
>
> I think we should check whether the timer has been allocated an IRQ before proceeding to assign one to it.
> Here is a patch that does this.
>
> Yinghai, could you please apply this on top of my patch and check ?
>
> ---
> Index: linux-2.6/arch/x86/kernel/hpet.c
> ===================================================================
> --- linux-2.6.orig/arch/x86/kernel/hpet.c
...
>

it works

YH

  reply	other threads:[~2008-01-16 21:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-16  3:32 Yinghai Lu
2008-01-16  6:51 ` Ingo Molnar
2008-01-16  8:34   ` Balaji Rao
2008-01-16 21:39     ` Yinghai Lu [this message]
2008-01-17 16:12       ` Balaji Rao
2008-01-18 12:41         ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86802c440801161339h4e3e983co67e05a231666d050@mail.gmail.com \
    --to=yhlu.kernel@gmail.com \
    --cc=balajirrao@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --subject='Re: hpet_late_init hang' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).