LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Yinghai Lu" <yhlu.kernel@gmail.com>
To: "Alexey Dobriyan" <adobriyan@sw.ru>
Cc: "Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
	linux-kernel@vger.kernel.org
Subject: Re: tg3 broken after "PCI: Fix bus resource assignment on 32 bits with 64b resources"
Date: Tue, 5 Feb 2008 02:07:29 -0800	[thread overview]
Message-ID: <86802c440802050207j60385efbif6f693dc0b1fd297@mail.gmail.com> (raw)
In-Reply-To: <20080205091758.GB26618@localhost.sw.ru>

On Feb 5, 2008 1:17 AM, Alexey Dobriyan <adobriyan@sw.ru> wrote:
> On Tue, Feb 05, 2008 at 08:54:33AM +1100, Benjamin Herrenschmidt wrote:
> >
> > On Mon, 2008-02-04 at 18:12 +0300, Alexey Dobriyan wrote:
> > > Commit c40a22e0ce5eb400f27449e59e43d021bee58b8d aka
> > > "PCI: Fix bus resource assignment on 32 bits with 64b resources"
> > > renders one tg3-equipped box networkless here.
> > >
> > >     tg3.c:v3.87 (December 20, 2007)
> > >     tg3: (0000:02:05.0) phy probe failed, err -19
> > >     tg3: Problem fetching invariants of chip, aborting.
> > >     tg3: (0000:02:05.1) phy probe failed, err -19
> > >     tg3: Problem fetching invariants of chip, aborting.
> > >
> > > It's 32-bit CONFIG_RESOURCES_64BIT=y box.
> > >
> > > Not sure what you need this, but below is some lspci -vvvxxx output:
> >
> > Interesting. It looks like the BAR of the tg3 has a spurrious 0x100000000
> > bit set to it. Can you send me a full dmesg, if possible enabling DEBUG
> > in the pci code (there's some places to turn DEBUG on in drivers/pci/*)
>
> OK, attached data collected on 2.6.24-9ef9dc69d4167276c04590d67ee55de8380bc1ad
> with CONFIG_PCI_DEBUG=y with and without your patch:
> (-000 means vanilla, -001 means with reverted patch)
>
> -rw-r--r-- 1 ad ad 25261 2008-02-05 12:08 tg3-000.dmesg
> -rw-r--r-- 1 ad ad  1112 2008-02-05 12:08 tg3-000.iomem
> -rw-r--r-- 1 ad ad 37785 2008-02-05 12:08 tg3-000.lspci
> -rw-r--r-- 1 ad ad 25495 2008-02-05 12:08 tg3-001.dmesg
> -rw-r--r-- 1 ad ad  1172 2008-02-05 12:08 tg3-001.iomem
> -rw-r--r-- 1 ad ad 37933 2008-02-05 12:08 tg3-001.lspci
>
> dmesg is full of such chunks:
> -  got res [180000000:180ffffff] bus [180000000:180ffffff] flags 200 for BAR 0 of 0000:03:04.0
> +  got res [180000000:180ffffff] bus [80000000:80ffffff] flags 200 for BAR 0 of 0000:03:04.0
>
> which is definitely not difference in formatting.
>

so x86_64 will work well?

the problem is that BIOS does not assign one resource for you tg3. and
kernel pcibios_assign_to_unassign (?) try
to assign resource to your card.

revert the patch happen to work, you only have 2g less RAM (?), so
0x8000000 still can be used.

sometime you could get hang if your MB have two HT chains. ...because
BIOS already allocate two io range for the two chain.
and kernel may assign resource from the range1 belong to HT1 to device
under HT0.
solution: need pci root bios to provide _CRS to replace...
and i have one patch but it only take care of 64 bit kernel for this case.


easy solution for you: try to get one updated BIOS.

YH

  reply	other threads:[~2008-02-05 10:07 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-04 15:12 Alexey Dobriyan
2008-02-04 21:54 ` Benjamin Herrenschmidt
2008-02-05  9:17   ` Alexey Dobriyan
2008-02-05 10:07     ` Yinghai Lu [this message]
2008-02-05 20:49       ` Benjamin Herrenschmidt
2008-02-06 10:05         ` Alexey Dobriyan
2008-02-06 10:40           ` Yinghai Lu
2008-02-06 21:15           ` Benjamin Herrenschmidt
2008-02-07 10:07             ` Alexey Dobriyan
2008-02-06  1:05     ` Benjamin Herrenschmidt
2008-02-04 21:57 ` Benjamin Herrenschmidt
2008-02-04 21:59 ` Benjamin Herrenschmidt
2008-02-13 22:52 ` Rafael J. Wysocki
2008-02-13 23:01   ` Benjamin Herrenschmidt
2008-02-13 23:03   ` Alexey Dobriyan
2008-02-13 23:06     ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86802c440802050207j60385efbif6f693dc0b1fd297@mail.gmail.com \
    --to=yhlu.kernel@gmail.com \
    --cc=adobriyan@sw.ru \
    --cc=benh@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: tg3 broken after "PCI: Fix bus resource assignment on 32 bits with 64b resources"' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).