LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] Fix "Malformed early option 'loglevel'"
@ 2008-02-28 15:44 Alex Riesen
  2008-02-28 17:38 ` Yinghai Lu
  0 siblings, 1 reply; 2+ messages in thread
From: Alex Riesen @ 2008-02-28 15:44 UTC (permalink / raw)
  To: trivial; +Cc: linux-kernel, Yinghai Lu

According to Rusty Russell in <1155086871.26428.5.camel@localhost.localdomain>:

    On Tue, 2006-08-08 at 17:10 -0700, Keith Mannthey wrote:
    > The parameter hotadd_percent is setup right but there is a
    > "Malformed early option 'numa'" message.

    For the record: this happens when the function registered with
    early_param() returns non-zero.  __setup() functions return 1 if OK,
    module_param() and early_param() return 0 or a -ve error code.
---

For instance:

Linux version 2.6.25-rc3-t (raa@steel) (gcc version 4.1.3 20070929 (prerelease) (Ubuntu 4.1.2-16ubuntu2)) #22 SMP PREEMPT Tue Feb 26
BIOS-provided physical RAM map:
 BIOS-e820: 0000000000000000 - 00000000000a0000 (usable)
 BIOS-e820: 00000000000f0000 - 0000000000100000 (reserved)
 BIOS-e820: 0000000000100000 - 000000003fff0000 (usable)
 BIOS-e820: 000000003fff0000 - 000000003fff3000 (ACPI NVS)
 BIOS-e820: 000000003fff3000 - 0000000040000000 (ACPI data)
 BIOS-e820: 00000000fec00000 - 0000000100000000 (reserved)
Malformed early option 'loglevel'
127MB HIGHMEM available.
896MB LOWMEM available.

Command line:

BOOT_IMAGE=2.6.25-t ro root=809 ro console=ttyS0,57600n8 console=tty0 loglevel=5

 init/main.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/init/main.c b/init/main.c
index 8b19820..fbb0167 100644
--- a/init/main.c
+++ b/init/main.c
@@ -254,7 +254,7 @@ early_param("quiet", quiet_kernel);
 static int __init loglevel(char *str)
 {
 	get_option(&str, &console_loglevel);
-	return 1;
+	return 0;
 }
 
 early_param("loglevel", loglevel);
-- 
1.5.4.3.253.g9f1d5



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Fix "Malformed early option 'loglevel'"
  2008-02-28 15:44 [PATCH] Fix "Malformed early option 'loglevel'" Alex Riesen
@ 2008-02-28 17:38 ` Yinghai Lu
  0 siblings, 0 replies; 2+ messages in thread
From: Yinghai Lu @ 2008-02-28 17:38 UTC (permalink / raw)
  To: Andrew Morton, Alex Riesen, trivial, linux-kernel, Yinghai Lu; +Cc: Andi Kleen

On Thu, Feb 28, 2008 at 7:44 AM, Alex Riesen <raa.lkml@gmail.com> wrote:
> According to Rusty Russell in <1155086871.26428.5.camel@localhost.localdomain>:
>
>     On Tue, 2006-08-08 at 17:10 -0700, Keith Mannthey wrote:
>     > The parameter hotadd_percent is setup right but there is a
>     > "Malformed early option 'numa'" message.
>
>     For the record: this happens when the function registered with
>     early_param() returns non-zero.  __setup() functions return 1 if OK,
>     module_param() and early_param() return 0 or a -ve error code.
>  ---
>
>  For instance:
>
>  Linux version 2.6.25-rc3-t (raa@steel) (gcc version 4.1.3 20070929 (prerelease) (Ubuntu 4.1.2-16ubuntu2)) #22 SMP PREEMPT Tue Feb 26
>  BIOS-provided physical RAM map:
>   BIOS-e820: 0000000000000000 - 00000000000a0000 (usable)
>   BIOS-e820: 00000000000f0000 - 0000000000100000 (reserved)
>   BIOS-e820: 0000000000100000 - 000000003fff0000 (usable)
>   BIOS-e820: 000000003fff0000 - 000000003fff3000 (ACPI NVS)
>   BIOS-e820: 000000003fff3000 - 0000000040000000 (ACPI data)
>   BIOS-e820: 00000000fec00000 - 0000000100000000 (reserved)
>  Malformed early option 'loglevel'
>  127MB HIGHMEM available.
>  896MB LOWMEM available.
>
>  Command line:
>
>  BOOT_IMAGE=2.6.25-t ro root=809 ro console=ttyS0,57600n8 console=tty0 loglevel=5
>
>   init/main.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
>  diff --git a/init/main.c b/init/main.c
>  index 8b19820..fbb0167 100644
>  --- a/init/main.c
>  +++ b/init/main.c
>  @@ -254,7 +254,7 @@ early_param("quiet", quiet_kernel);
>   static int __init loglevel(char *str)
>   {
>         get_option(&str, &console_loglevel);
>  -       return 1;
>  +       return 0;
>   }
>
>   early_param("loglevel", loglevel);
>  --
>  1.5.4.3.253.g9f1d5

Acked-by: Yinghai Lu <yhlu.kernel@gmai.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-02-28 17:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-28 15:44 [PATCH] Fix "Malformed early option 'loglevel'" Alex Riesen
2008-02-28 17:38 ` Yinghai Lu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).